Skip to content

Commit 31540ad

Browse files
odubajDTtoddbaert
andcommitted
Apply suggestions from code review
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: odubajDT <93584209+odubajDT@users.noreply.github.com>
1 parent 4108c32 commit 31540ad

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

docs/annotations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ Example:
3333

3434
### `openfeature.dev/featureflaginprocessconfiguration`
3535

36-
This annotation specifies the names of the `FeatureFlagInProcessConfigurations` used to configure the injected environment variables.
36+
This annotation specifies the names of the `FeatureFlagInProcessConfigurations` used to configure the injected environment variables to support flagd's [in-process evaluation mode](https://flagd.dev/architecture/#in-process-evaluation).
3737
The annotation value is a comma separated list of values following one of 2 patterns: {NAME} or {NAMESPACE}/{NAME}.
3838

3939
If no namespace is provided, it is assumed that the custom resource is within the **same namespace** as the annotated pod.

docs/feature_flag_in_process_configuration.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,12 @@ spec:
2525
value: "val2"
2626
```
2727
28-
## How it works?
28+
## How does it work?
2929
3030
Similar to usage of [FeatureFlagSource](./feature_flag_source.md) configuration,
3131
[annotations](./annotations.md#) are used to allow the injection of configuration data
3232
into the annotated Pod.
33-
The mutating webhook parses the annotations, retrieves the referenced `FeatureFlagInProcessConfiguration`
34-
resources from the cluster and injects the data from the resource into all containers of the Pod via environment variables,
35-
which are read by the application using the in-process feature flag evaluation.
33+
The mutating webhook parses the annotations, retrieves the referenced `FeatureFlagInProcessConfiguration` resources from the cluster and injects the data from the resource into all containers of the Pod via environment variables, which configure the provider in the workload to consume feature flag configuration from the available [sync implementation](https://flagd.dev/concepts/syncs/#grpc-sync) specified by the configuration.
3634

3735
## Merging of configurations
3836

0 commit comments

Comments
 (0)