Skip to content

Commit 2b953e0

Browse files
committed
Add timeout to EventProviderTest
With the events being executed on a different thread, we need to wait to make sure the thread is scheduled to have the events emitted. Signed-off-by: Philipp Fehre <philipp@fehre.co.uk>
1 parent cdc1a4f commit 2b953e0

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/test/java/dev/openfeature/sdk/EventProviderTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,7 @@
22

33
import static org.junit.jupiter.api.Assertions.assertThrows;
44
import static org.mockito.ArgumentMatchers.any;
5-
import static org.mockito.Mockito.mock;
6-
import static org.mockito.Mockito.never;
7-
import static org.mockito.Mockito.times;
8-
import static org.mockito.Mockito.verify;
5+
import static org.mockito.Mockito.*;
96

107
import dev.openfeature.sdk.internal.TriConsumer;
118
import dev.openfeature.sdk.testutils.TestStackedEmitCallsProvider;
@@ -15,9 +12,12 @@
1512
import org.junit.jupiter.api.DisplayName;
1613
import org.junit.jupiter.api.Test;
1714
import org.junit.jupiter.api.Timeout;
15+
import org.mockito.Mockito;
1816

1917
class EventProviderTest {
2018

19+
private static final int TIMEOUT = 300;
20+
2121
private TestEventProvider eventProvider;
2222

2323
@BeforeEach
@@ -45,10 +45,10 @@ void emitsEventsWhenAttached() {
4545
eventProvider.emitProviderStale(details);
4646
eventProvider.emitProviderError(details);
4747

48-
verify(onEmit, times(2)).accept(eventProvider, ProviderEvent.PROVIDER_READY, details);
49-
verify(onEmit, times(1)).accept(eventProvider, ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, details);
50-
verify(onEmit, times(1)).accept(eventProvider, ProviderEvent.PROVIDER_STALE, details);
51-
verify(onEmit, times(1)).accept(eventProvider, ProviderEvent.PROVIDER_ERROR, details);
48+
verify(onEmit, timeout(TIMEOUT).times(2)).accept(eventProvider, ProviderEvent.PROVIDER_READY, details);
49+
verify(onEmit, timeout(TIMEOUT)).accept(eventProvider, ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, details);
50+
verify(onEmit, timeout(TIMEOUT)).accept(eventProvider, ProviderEvent.PROVIDER_STALE, details);
51+
verify(onEmit, timeout(TIMEOUT)).accept(eventProvider, ProviderEvent.PROVIDER_ERROR, details);
5252
}
5353

5454
@Test

0 commit comments

Comments
 (0)