Skip to content

Commit dcf8d5c

Browse files
committed
Sprinkling of comments
Signed-off-by: Rob Crowe <nobby.crowe@gmail.com>
1 parent b443359 commit dcf8d5c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

providers/configcat/internal/clienttest/client.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
sdk "github.com/configcat/go-sdk/v7"
77
)
88

9+
// NewClient creates enough of the ConfigCat client to record flag interactions.
910
func NewClient() *Client {
1011
return &Client{}
1112
}

providers/configcat/pkg/provider.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,23 @@ import (
1010
"github.com/open-feature/go-sdk/pkg/openfeature"
1111
)
1212

13+
var _ openfeature.FeatureProvider = (*Provider)(nil)
14+
15+
// Evaluation ctx keys that are mapped to ConfigCat user data.
1316
const (
1417
IdentifierKey = openfeature.TargetingKey
1518
EmailKey = "email"
1619
CountryKey = "country"
1720
)
1821

19-
var _ openfeature.FeatureProvider = (*Provider)(nil)
20-
2122
type Client interface {
2223
GetBoolValueDetails(key string, defaultValue bool, user sdk.User) sdk.BoolEvaluationDetails
2324
GetStringValueDetails(key string, defaultValue string, user sdk.User) sdk.StringEvaluationDetails
2425
GetFloatValueDetails(key string, defaultValue float64, user sdk.User) sdk.FloatEvaluationDetails
2526
GetIntValueDetails(key string, defaultValue int, user sdk.User) sdk.IntEvaluationDetails
2627
}
2728

29+
// NewProvider creates an OpenFeature provider backed by ConfigCat.
2830
func NewProvider(client Client) *Provider {
2931
return &Provider{
3032
client: client,
@@ -35,12 +37,14 @@ type Provider struct {
3537
client Client
3638
}
3739

40+
// Metadata returns value of Metadata (name of current service, exposed to openfeature sdk)
3841
func (p *Provider) Metadata() openfeature.Metadata {
3942
return openfeature.Metadata{
4043
Name: "ConfigCat",
4144
}
4245
}
4346

47+
// Hooks are not currently implemented, an empty slice is returned.
4448
func (p *Provider) Hooks() []openfeature.Hook {
4549
return nil
4650
}
@@ -109,6 +113,7 @@ func (p *Provider) IntEvaluation(ctx context.Context, flag string, defaultValue
109113
}
110114
}
111115

116+
// ObjectEvaluation attempts to parse a string feature flag value as JSON.
112117
func (p *Provider) ObjectEvaluation(ctx context.Context, flag string, defaultValue interface{}, evalCtx openfeature.FlattenedContext) openfeature.InterfaceResolutionDetail {
113118
user, errDetails := toUserData(evalCtx)
114119
if errDetails != nil {

0 commit comments

Comments
 (0)