Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix units in Rhs2116DataFrame xml comment #355

Open
cjsha opened this issue Oct 29, 2024 · 0 comments
Open

Fix units in Rhs2116DataFrame xml comment #355

cjsha opened this issue Oct 29, 2024 · 0 comments

Comments

@cjsha
Copy link
Member

cjsha commented Oct 29, 2024 •
edited
Loading

I'm guessing the mv needs to be µV.

The offending lines:

bonsai-onix1/OpenEphys.Onix1/Rhs2116DataFrame.cs

Line 48 in 634a54c

/// V_electrode (mV) = -19.23 mV × (ADC result – 512)

bonsai-onix1/OpenEphys.Onix1/Rhs2116DataFrame.cs

Line 34 in 634a54c

/// V_electrode (uV) = 0.195 µV × (ADC result – 32768)

I linked the second line as well because we use "uV" in the first instance and "µV" in the second instance.

This screenshot shows what I'm referring to. Look at the (micro-/milli-)Volt units.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjsha