Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to click to select/deselect channels in ChannelConfigurationDialog #354

Open
bparks13 opened this issue Oct 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working enhancement This feature already exists but could be improved
Milestone

Comments

@bparks13
Copy link
Member

Due to the current implementation of selecting and deselecting channels, there is overlapping functionality between just click, and click-and-drag. If the mouse moves even the smallest distance while clicking it will generate a click-and-drag event which then has a rectangle that is too small to select anything, and also precludes the user from deselecting since click-and-drag is only used to select channels.

One easy step:

  • Check for the size of the selected rectangle, and if it is below a certain size then treat the event as a single click, which then gives back the power to deselect via a click event.

Other possible solutions:

  • Add in a button that needs to be held to deselect (i.e., Shift + click), which can be for Shift + click-and-drag as well to bulk deselect channels
@bparks13 bparks13 added the enhancement This feature already exists but could be improved label Oct 28, 2024
@bparks13 bparks13 added this to the 0.5.0 milestone Oct 28, 2024
@bparks13 bparks13 self-assigned this Oct 28, 2024
@bparks13 bparks13 added the bug Something isn't working label Oct 30, 2024
@bparks13
Copy link
Member Author

Upon further testing, it appears that if there is more than one probe listed (such as in Rhs2116ChannelConfigurationDialog) the offset of the first probe is not taken into account when grabbing the index of the contact. This is an error, and should be corrected by applying the offset of all probes to the current index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement This feature already exists but could be improved
Projects
None yet
Development

No branches or pull requests

1 participant