Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-periodic waveforms in Rhs2116StimulusSequenceDialog #341

Open
bparks13 opened this issue Oct 18, 2024 · 0 comments
Open

Allow non-periodic waveforms in Rhs2116StimulusSequenceDialog #341

bparks13 opened this issue Oct 18, 2024 · 0 comments
Assignees
Labels
feature New planned feature
Milestone

Comments

@bparks13
Copy link
Member

Currently in the Rhs2116StimulusSequenceDialog the only option to add a waveform is to apply a periodic waveform on a channel, overriding the existing stimulus if it exists.

The hardware allows for a much more flexible stimulation schedule, including non-periodic pulses. This should be implemented as a way to add pulses to the end of an existing waveform so that two (or more) pulse trains with different pulse widths and inter-stimulus intervals can be included on the same channel.

To accomplish this, the main library will need to be updated to decouple the delta table from the anodic / cathodic steps and widths. Currently, the delta table is built based off of the assumption of periodic waveforms, but if it is extended to allow for arbitrary periodicity then the Design library can simply read these waveforms and plot as-is. Additionally, the functionality to add non-periodic waveforms to existing waveforms would need to be implemented from the main library as well so that it can be easily extended to the GUI.

@bparks13 bparks13 added the feature New planned feature label Oct 18, 2024
@bparks13 bparks13 added this to the 0.5.0 milestone Oct 18, 2024
@bparks13 bparks13 self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

No branches or pull requests

1 participant