Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that Neuropixels Calibration files match an expected format #228

Closed
bparks13 opened this issue Aug 20, 2024 · 0 comments · Fixed by #291
Closed

Check that Neuropixels Calibration files match an expected format #228

bparks13 opened this issue Aug 20, 2024 · 0 comments · Fixed by #291
Assignees
Milestone

Comments

@bparks13
Copy link
Member

Anytime we are opening a file to read data, we should ensure that the file matches an expected format so that it doesn't throw any weird exceptions.

For example, when checking NeuropixelsV2e gain correction files, an incorrectly formatted file leads to weird exceptions that are not very useful for the end user.

There are other areas where we pull data from files without checking if they match some expected format; we can use this issue as a meta-issue to track individual areas where this might be necessary to add some logic for checking file formats.

Related: All GUI functions that are touching the same files should not reimplement logic, but should call these new checking functions and loading functions from the base library.

@bparks13 bparks13 added this to the 0.3.0 milestone Aug 20, 2024
@jonnew jonnew changed the title Check that files match an expected format Check that Neuropixels Calibration files match an expected format Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant