Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration dialog for ONI context #19

Open
glopesdev opened this issue Aug 29, 2023 · 3 comments
Open

Add configuration dialog for ONI context #19

glopesdev opened this issue Aug 29, 2023 · 3 comments
Labels
feature New planned feature
Milestone

Comments

@glopesdev
Copy link
Collaborator

First iteration can adapt functionalities of the existing ONI Context GUI of the original package, accessing liboni directly.

@glopesdev glopesdev added the feature New planned feature label Aug 29, 2023
@glopesdev glopesdev added this to the 0.1.0 milestone Aug 29, 2023
@glopesdev
Copy link
Collaborator Author

@jonnew I am assuming we are moving this to the 0.2.0 milestone.

@glopesdev glopesdev modified the milestones: 0.1.0, 0.2.0 Jul 2, 2024
@jonnew
Copy link
Member

jonnew commented Jul 3, 2024

Yes, I think thats reasonable.

@jonnew
Copy link
Member

jonnew commented Aug 13, 2024

During a meeting, we started discussing what this would actually look like and realized there are a lot of details to consider

  • Should this configuration dialog actually access hardware?
  • Should it reflect the state that would be applied during the configuration chain? Should it apply the configuration chain? This is important because be default, e.g., the headstage ports are powered off. Does it need to turn them on to figure out the true device table or just tell the user what will be applied in the configuration chain if the devices are actually present when the play button is pressed.
  • etc.

To be honest, as the conversation progressed, we began to question the utility of this idea at all. The library has improved significantly compared to Bonsai.ONIX in terms of abstracting away the hardware details. Providing a direct window into the device table or showing real hardware state seems like a move in the other direction.

There is one major type of information that it would be nice to have access to though which is the hardware IDs, firmware versions, etc. that are produced by the following function:

https://github.com/open-ephys/onix-bonsai-onix1/blob/7ac700fb8a696d4d9f8d97c9d1b85765b9951ca6/OpenEphys.Onix1/ContextTask.cs#L479C26-L479C32

This is useful diagnostic information that is not exposed in a way that the user can currently save or examine.

We are moving this to 0.3.0 for this reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

No branches or pull requests

2 participants