Skip to content

Conversation

@iedis
Copy link

@iedis iedis commented May 10, 2025

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

@razvand razvand self-requested a review May 17, 2025 07:47
@razvand razvand self-assigned this May 17, 2025
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ending newlines.

Sign-off-your commit.

Use proper name for author and signed-off-by.

Enhance your commit with a commit description. Use instructions here.

Comment on lines 1 to 29
# --- Build ---
FROM gcc:latest AS builder

# Set working directory
WORKDIR /app

# Copy the source code
COPY ./rwslotmachine5.c .

# Build the C program
RUN gcc -o rwslotmachine5 rwslotmachine5.c

# --- Runtime ---
FROM ubuntu:22.04

# Install minimal libraries needed for runtime
RUN apt-get update && apt-get install -y libstdc++6 && rm -rf /var/lib/apt/lists/*

# Set working directory
WORKDIR /app

# Copy compiled binary from builder stage
COPY --from=builder /app/rwslotmachine5 .

# Expose port
EXPOSE 31348

# Run the executable
CMD ["/app/rwslotmachine5"] No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many comments. Some of the commands are self-explanatory, remove those comments.

@iedis iedis force-pushed the 05-rwslotmachine5-dockerfile branch from 1d0dc78 to c4f6c7e Compare May 17, 2025 11:26
Signed-off-by: Edis Perchiata <edisperchiata@yahoo.com>

05-rwslotmachine5: Clean up code

Remove unnecessary comments and add ending newline in Makefile and Dockerfile

Signed-off-by: Edis Perchiata <edisperchiata@yahoo.com>
@iedis iedis force-pushed the 05-rwslotmachine5-dockerfile branch from c4f6c7e to bb5a054 Compare May 17, 2025 11:30
@iedis iedis requested a review from razvand May 18, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants