Skip to content

Commit 8f1ef19

Browse files
dwesolowMarkRedeman
authored andcommitted
refactor(inspect): Update photo placeholder to use indicator instead of email (#2990)
refactor: Update photo placeholder to use indicator instead of email
1 parent 0a2af70 commit 8f1ef19

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

application/ui/src/features/inspect/projects-management/project-list-item/project-list-item.component.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,12 @@ export const ProjectListItem = ({ project, isInEditMode, onBlur }: ProjectListIt
8989
<ProjectEdition name={project.name} onBlur={handleBlur(project.id)} />
9090
) : (
9191
<Flex alignItems={'center'} gap={'size-100'}>
92-
<PhotoPlaceholder name={project.name} email='' height={'size-300'} width={'size-300'} />
92+
<PhotoPlaceholder
93+
name={project.name}
94+
indicator={project.id ?? project.name}
95+
height={'size-300'}
96+
width={'size-300'}
97+
/>
9398
<Text>{project.name}</Text>
9499
</Flex>
95100
)}

application/ui/src/features/inspect/projects-management/projects-list-panel.component.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,15 @@ import styles from './projects-list.module.scss';
3030

3131
interface SelectedProjectProps {
3232
name: string;
33+
id: string | undefined;
3334
}
3435

35-
const SelectedProjectButton = ({ name }: SelectedProjectProps) => {
36+
const SelectedProjectButton = ({ name, id }: SelectedProjectProps) => {
3637
return (
3738
<ActionButton aria-label={`Selected project ${name}`} isQuiet height={'max-content'} staticColor='white'>
3839
<View margin={'size-50'}>{name}</View>
3940
<View margin='size-50'>
40-
<PhotoPlaceholder name={name} email='' height={'size-400'} width={'size-400'} />
41+
<PhotoPlaceholder name={name} indicator={id ?? name} height={'size-400'} width={'size-400'} />
4142
</View>
4243
</ActionButton>
4344
);
@@ -86,18 +87,19 @@ export const ProjectsListPanel = () => {
8687

8788
const [projectInEdition, setProjectInEdition] = useState<string | null>(null);
8889

89-
const selectedProjectName = data.projects.find((project) => project.id === projectId)?.name || '';
90+
const selectedProject = data.projects.find((project) => project.id === projectId);
91+
const selectedProjectName = selectedProject?.name ?? '';
9092

9193
return (
9294
<DialogTrigger type='popover' hideArrow>
93-
<SelectedProjectButton name={selectedProjectName} />
95+
<SelectedProjectButton name={selectedProjectName} id={selectedProject?.id} />
9496

9597
<Dialog width={'size-4600'} UNSAFE_className={styles.dialog}>
9698
<Header>
9799
<Flex direction={'column'} justifyContent={'center'} width={'100%'} alignItems={'center'}>
98100
<PhotoPlaceholder
99101
name={selectedProjectName}
100-
email=''
102+
indicator={selectedProject?.id ?? selectedProjectName}
101103
height={'size-1000'}
102104
width={'size-1000'}
103105
/>

0 commit comments

Comments
 (0)