-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot specify which resources to override in ClusterOverrides. #45
Comments
/assign @mikeshng |
Hi @ivan-cai , For Helm subscriptions see https://github.com/open-cluster-management-io/multicloud-operators-subscription/blob/main/examples/helmrepo-channel/02-subscription.yaml#L10-L17 as an example to override chart values which can edit the resources. As for
|
thx @mikeshng, but I also want to know the reason for cannot specifying resources' kind and name. |
I think it comes down to audit/traceability. One of the benefits of GitOps is that git commits can be use as a history of changes that were applied. If the subscription spec has resource override then the changes in git commits might not actually reflect on what actually were applied. |
I wonder why cannot specify which resources(apiversion,kind,name...) to override in ClusterOverrides(subscription.spec.overrides). Is it because of the overrides only apply to the application dimension, not resource dimension?
multicloud-operators-subscription/pkg/apis/apps/v1/subscription_types.go
Line 167 in 4e2c4d0
The text was updated successfully, but these errors were encountered: