refactoring for easy unit-test and cm-cli integration #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominique Vernier <dvernier@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: itdove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
Signed-off-by: Dominique Vernier <dvernier@redhat.com>
Signed-off-by: Dominique Vernier <dvernier@redhat.com>
qiujian16
reviewed
Jun 7, 2021
pkg/cmd/join/exec.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| //quick fix for https://github.com/open-cluster-management-io/clusteradm/issues/12 | ||
| fmt.Printf("Wait 10 sec... for the crd to be effective\n") |
There was a problem hiding this comment.
you could use wait.Until here to get crd of clustermanager.
Signed-off-by: Dominique Vernier <dvernier@redhat.com>
Signed-off-by: Dominique Vernier <dvernier@redhat.com>
|
/unhold |
ycyaoxdu
pushed a commit
to ycyaoxdu/clusteradm
that referenced
this pull request
Feb 8, 2023
* upgrade to kubernetes 1.25.4 Signed-off-by: clyang82 <chuyang@redhat.com> * upgrade apiextensions-apiserver as well Signed-off-by: clyang82 <chuyang@redhat.com> Signed-off-by: clyang82 <chuyang@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring for easy unit-tests and cm-cli integration
Also quick fix for : #12
Remove the "verbs" notion, use groups like oc
Signed-off-by: Dominique Vernier dvernier@redhat.com