Merge FaqGen into ChatQnA #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files
|
XinyaoWa
force-pushed
the
faqgen_merge
branch
4 times, most recently
from
0a3b373 to
0ec52ee
Compare
XinyaoWa
force-pushed
the
faqgen_merge
branch
3 times, most recently
from
dca32af to
6b9acd0
Compare
Refactor FaqGen into ChatQnA, serve as a LLM selection Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
XinyaoWa
force-pushed
the
faqgen_merge
branch
3 times, most recently
from
38236c3 to
33fe3b4
Compare
for more information, see https://pre-commit.ci
4 tasks
Remove Dockerfile.faqgen, Dockerfile.without_rerank, Dockerfile.guardrails Combine all types into Dockerfile, use env CHATQNA_TYPE to make selection Signed-off-by: Xinyao Wang <xinyao.wang@intel.com>
|
This change will impact helm charts and benchmark, @yongfengdu @bjzhjing please aware. |
lvliang-intel
approved these changes
Mar 20, 2025
|
ROCm issue is not caused by this PR, it failed in main branch. So let's merge this PR first and create an issue to trace. #1699 |
chensuyue
approved these changes
Mar 20, 2025
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Mar 21, 2025
1. Delete FaqGen 2. Refactor FaqGen into ChatQnA, serve as a LLM selection. 3. Combine all ChatQnA related Dockerfile into one Signed-off-by: Xinyao Wang <xinyao.wang@intel.com> Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
eero-t
reviewed
Mar 25, 2025
Comment on lines
+4
to
+14
| chatqna_arg=$CHATQNA_TYPE | ||
|
|
||
| if [[ $chatqna_arg == "CHATQNA_FAQGEN" ]]; then | ||
| python chatqna.py --faqgen | ||
| elif [[ $chatqna_arg == "CHATQNA_NO_RERANK" ]]; then | ||
| python chatqna.py --without-rerank | ||
| elif [[ $chatqna_arg == "CHATQNA_GUARDRAILS" ]]; then | ||
| python chatqna.py --with-guardrails | ||
| else | ||
| python chatqna.py | ||
| fi |
There was a problem hiding this comment.
Why this logic was added to a separate script instead of directly into chatqna.py?
8 tasks
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Apr 1, 2025
1. Delete FaqGen 2. Refactor FaqGen into ChatQnA, serve as a LLM selection. 3. Combine all ChatQnA related Dockerfile into one Signed-off-by: Xinyao Wang <xinyao.wang@intel.com> Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
Apr 1, 2025
1. Delete FaqGen 2. Refactor FaqGen into ChatQnA, serve as a LLM selection. 3. Combine all ChatQnA related Dockerfile into one Signed-off-by: Xinyao Wang <xinyao.wang@intel.com> Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
May 16, 2025
1. Delete FaqGen 2. Refactor FaqGen into ChatQnA, serve as a LLM selection. 3. Combine all ChatQnA related Dockerfile into one Signed-off-by: Xinyao Wang <xinyao.wang@intel.com> Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.