Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Isthmus Upgrade Gas and User Tx Omission #1247

Closed
wants to merge 2 commits into from

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Mar 12, 2025

Description

Implements ethereum-optimism/optimism#14797 in kona, applying upgrade gas to the payload attributes.

Ensures user txs are omitted for the activation block.

@refcell refcell added A-protocol Area: protocol crates K-feature Kind: feature labels Mar 12, 2025
@refcell refcell requested review from clabby and emhane as code owners March 12, 2025 00:36
@refcell refcell self-assigned this Mar 12, 2025
@refcell
Copy link
Collaborator Author

refcell commented Mar 12, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell added the H-isthmus Hardfork: Isthmus related label Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.3%. Comparing base (4a69448) to head (bd4ae7a).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/protocol/genesis/src/rollup.rs 80.0% 2 Missing ⚠️
crates/protocol/protocol/src/batch/single.rs 98.7% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@refcell refcell marked this pull request as draft March 12, 2025 13:35
@refcell
Copy link
Collaborator Author

refcell commented Mar 12, 2025

🧊

@refcell
Copy link
Collaborator Author

refcell commented Mar 12, 2025

@refcell
Copy link
Collaborator Author

refcell commented Mar 12, 2025

Closing this PR out for now.

I've written up a ticket to track. #1252

@refcell refcell closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-protocol Area: protocol crates H-isthmus Hardfork: Isthmus related K-feature Kind: feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant