Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make node's role permission more finegrain #22

Open
xshot9011 opened this issue Jan 26, 2024 · 0 comments
Open

feat: make node's role permission more finegrain #22

xshot9011 opened this issue Jan 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@xshot9011
Copy link
Contributor

xshot9011 commented Jan 26, 2024

Is your feature request related to a problem? Please describe.

Feel free to correct me if I am wrong.

Describe the solution you'd like

# InsideEKS
## Remove defualt workernode add on permission

# When using
module "eks" {
   ...
}

# define sa (iam, role) and it's permission here

resource "aws_eks_addon" "this" {
  cluster_name             = module.eks.cluster_name
  ...
  service_account_role_arn = resouce.service_account_for_that_addon"
}

Describe alternatives you've considered
or make toggle feature

module "eks" {
  is_enable_vpc_cni = true
  vpc_cni_addon = {
     it
  }
}

but i think this way is hard to manage and duplicate resource configuration and messy terraform code

Additional context
Add any other context or screenshots about the feature request here.

@xshot9011 xshot9011 added the enhancement New feature or request label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant