Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BuilderOption: keepEntityCharRefs #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonkhanlar
Copy link

@jasonkhanlar jasonkhanlar commented Apr 8, 2022

Please include a summary of the change and which issue is fixed. Fixes # I have no idea if this fixes anything other than my own personal fix that seems to be sufficient for my use case, and I thought I'd share in case anyone may want to consider creating their own code to reproduce this or whatever. You can even reject this pull request as it is not intended to be of any value or use otherwise even if it is of value or use, because anyone and everyone can probably figure out this themselves without me contributing such code, however, since nobody seems to have done so, I tried to make sense of something (or at least I think I did, but I don't even know what I'm doing so I have no idea if this even makes sense)

keepEntityCharRefs:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Notes (delete after reading):

  • Please make sure this change is thoroughly tested. Add your tests to the test folder in a relevant sub folder. If this pull request is a bug fix, add a test specific to the fixed issue in the test/issues sub folder. If this change decreases code coverage you may be asked to add additional tests.

I have no idea how to thoroughly test anything, but I did write lots of English language words here: #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant