feat: hide settings notifications on desktop (#642)

Author: aanorbel

composeApp/src/commonMain/kotlin/org/ooni/probe/di/Dependencies.kt

@@ -318,6 +318,7 @@ class Dependencies(
             clearStorage = clearStorage::invoke,
             supportsCrashReporting = flavorConfig.isCrashReportingEnabled,
             knownBatteryState = platformInfo.knownBatteryState,
+            supportsNotificationSettings = platformInfo.supportsNotificationSettings,
         )
     }
 

composeApp/src/commonMain/kotlin/org/ooni/probe/domain/GetSettings.kt

@@ -75,6 +75,7 @@ class GetSettings(
     val observeStorageUsed: () -> Flow<Long>,
     private val supportsCrashReporting: Boolean,
     private val knownBatteryState: Boolean,
+    private val supportsNotificationSettings: Boolean,
 ) {
     operator fun invoke(): Flow<List<SettingsCategoryItem>> {
         return combine(
@@ -103,6 +104,26 @@ class GetSettings(
         }
     }
 
+    private fun createNotificationsSettings(): SettingsCategoryItem {
+        return SettingsCategoryItem(
+            icon = Res.drawable.notifications,
+            title = Res.string.Settings_Notifications_Label,
+            route = PreferenceCategoryKey.NOTIFICATIONS,
+            settings = listOf(
+                SettingsItem(
+                    title = Res.string.Settings_Notifications_Enabled,
+                    key = SettingsKey.NOTIFICATIONS_ENABLED,
+                    type = PreferenceItemType.SWITCH,
+                ),
+            ),
+            footerContent = {
+                SettingsDescription(
+                    Res.string.Modal_EnableNotifications_Paragraph,
+                )
+            },
+        )
+    }
+
     private fun buildSettings(
         hasWebsitesDescriptor: Boolean,
         uploadResultsEnabled: Boolean,
@@ -114,23 +135,7 @@ class GetSettings(
         supportsCrashReporting: Boolean = false,
     ): List<SettingsCategoryItem> {
         return listOfNotNull(
-            SettingsCategoryItem(
-                icon = Res.drawable.notifications,
-                title = Res.string.Settings_Notifications_Label,
-                route = PreferenceCategoryKey.NOTIFICATIONS,
-                settings = listOf(
-                    SettingsItem(
-                        title = Res.string.Settings_Notifications_Enabled,
-                        key = SettingsKey.NOTIFICATIONS_ENABLED,
-                        type = PreferenceItemType.SWITCH,
-                    ),
-                ),
-                footerContent = {
-                    SettingsDescription(
-                        Res.string.Modal_EnableNotifications_Paragraph,
-                    )
-                },
-            ),
+            createNotificationsSettings().takeIf { supportsNotificationSettings },
             SettingsCategoryItem(
                 icon = Res.drawable.ic_settings,
                 title = Res.string.Settings_TestOptions_Label,

composeApp/src/commonMain/kotlin/org/ooni/probe/shared/PlatformInfo.kt

@@ -7,6 +7,7 @@ data class PlatformInfo(
     val osVersion: String,
     val model: String,
     val needsToRequestNotificationsPermission: Boolean,
+    val supportsNotificationSettings: Boolean = true,
     val knownBatteryState: Boolean = true,
     val sentryDsn: String,
 ) {

composeApp/src/desktopMain/kotlin/org/ooni/probe/BuildDependencies.kt

@@ -54,6 +54,7 @@ private fun buildPlatformInfo() =
         osVersion = "1.0",
         model = "model",
         needsToRequestNotificationsPermission = false,
+        supportsNotificationSettings = false,
         knownBatteryState = false,
         sentryDsn = "",
     )