chore: extract bundle configuration item (#146)

Author: aanorbel

iosApp/Configuration/Config.xcconfig

@@ -1,3 +1,7 @@
-TEAM_ID=
+OONI_TEAM_ID=
+OONI_PROBE_BUNDLE_ID=org.ooni.probe
+OONI_PROBE_APP_NAME=OONI Probe
+NMS_BUNDLE_ID=org.dw.probe
+NMS_APP_NAME=News Media Scan
+NMS_TEAM_ID=
 BUNDLE_ID=org.ooni.probe.OONIProbe
-APP_NAME=OONI Probe

iosApp/iosApp.xcodeproj/project.pbxproj

@@ -630,7 +630,7 @@
 				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
-				DEVELOPMENT_TEAM = "${TEAM_ID}";
+				DEVELOPMENT_TEAM = "${OONI_TEAM_ID}";
 				ENABLE_PREVIEWS = YES;
 				FRAMEWORK_SEARCH_PATHS = (
 					"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
@@ -648,9 +648,9 @@
 					"-framework",
 					composeApp,
 				);
-				PRODUCT_BUNDLE_IDENTIFIER = org.ooni.probe.debug;
-				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.ooni.probe.debug;
-				PRODUCT_NAME = "${APP_NAME}";
+				PRODUCT_BUNDLE_IDENTIFIER = "${OONI_PROBE_BUNDLE_ID}.debug";
+				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${OONI_PROBE_BUNDLE_ID}.debug";
+				PRODUCT_NAME = "${OONI_PROBE_APP_NAME}";
 				PROVISIONING_PROFILE_SPECIFIER = "";
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
@@ -666,7 +666,7 @@
 				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
-				DEVELOPMENT_TEAM = "${TEAM_ID}";
+				DEVELOPMENT_TEAM = "${OONI_TEAM_ID}";
 				ENABLE_PREVIEWS = YES;
 				FRAMEWORK_SEARCH_PATHS = (
 					"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
@@ -684,9 +684,9 @@
 					"-framework",
 					composeApp,
 				);
-				PRODUCT_BUNDLE_IDENTIFIER = org.ooni.probe;
-				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.ooni.probe;
-				PRODUCT_NAME = "${APP_NAME}";
+				PRODUCT_BUNDLE_IDENTIFIER = "${OONI_PROBE_BUNDLE_ID}";
+				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${OONI_PROBE_BUNDLE_ID}";
+				PRODUCT_NAME = "${OONI_PROBE_APP_NAME}";
 				PROVISIONING_PROFILE_SPECIFIER = "";
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
@@ -701,7 +701,7 @@
 				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
-				DEVELOPMENT_TEAM = "${TEAM_ID}";
+				DEVELOPMENT_TEAM = "${NMS_TEAM_ID}";
 				ENABLE_PREVIEWS = YES;
 				FRAMEWORK_SEARCH_PATHS = (
 					"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
@@ -719,9 +719,9 @@
 					"-framework",
 					composeApp,
 				);
-				PRODUCT_BUNDLE_IDENTIFIER = org.dw.probe.debug;
-				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.dw.probe.debug;
-				PRODUCT_NAME = "$(TARGET_NAME)";
+				PRODUCT_BUNDLE_IDENTIFIER = "${NMS_BUNDLE_ID}.debug";
+				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${NMS_BUNDLE_ID}.debug";
+				PRODUCT_NAME = "${NMS_APP_NAME}";
 				PROVISIONING_PROFILE_SPECIFIER = "";
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";
@@ -736,7 +736,7 @@
 				CODE_SIGN_IDENTITY = "Apple Development";
 				CODE_SIGN_STYLE = Automatic;
 				DEVELOPMENT_ASSET_PATHS = "\"iosApp/Preview Content\"";
-				DEVELOPMENT_TEAM = "${TEAM_ID}";
+				DEVELOPMENT_TEAM = "${NMS_TEAM_ID}";
 				ENABLE_PREVIEWS = YES;
 				FRAMEWORK_SEARCH_PATHS = (
 					"$(SRCROOT)/../shared/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)",
@@ -754,9 +754,9 @@
 					"-framework",
 					composeApp,
 				);
-				PRODUCT_BUNDLE_IDENTIFIER = org.dw.probe;
-				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = org.dw.probe;
-				PRODUCT_NAME = "$(TARGET_NAME)";
+				PRODUCT_BUNDLE_IDENTIFIER = "${NMS_BUNDLE_ID}";
+				"PRODUCT_BUNDLE_IDENTIFIER[sdk=iphoneos*]" = "${NMS_BUNDLE_ID}";
+				PRODUCT_NAME = "${NMS_APP_NAME}";
 				PROVISIONING_PROFILE_SPECIFIER = "";
 				SWIFT_VERSION = 5.0;
 				TARGETED_DEVICE_FAMILY = "1,2";