Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow setting Onyx::SQL::Repository#db with DB::Transaction instances #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow setting Onyx::SQL::Repository#db with DB::Transaction instances #107

wants to merge 1 commit into from

Conversation

repomaa
Copy link

@repomaa repomaa commented Jul 24, 2019

closes #97

@vladfaust
Copy link
Member

Hey, @repomaa, welcome back 😉

Would you mind adding some specs?

@repomaa repomaa force-pushed the topic/transaction_assignment branch from c320430 to fe00e3a Compare July 24, 2019 21:45
@repomaa
Copy link
Author

repomaa commented Jul 24, 2019

Hey @vladfaust o/
I overlooked the db_spec dir. I hope the added specs are what you were roughly thinking of.

@repomaa repomaa force-pushed the topic/transaction_assignment branch from fe00e3a to 7480f09 Compare July 24, 2019 21:49
vladfaust
vladfaust requested changes Jul 25, 2019
View reviewed changes
@repomaa repomaa force-pushed the topic/transaction_assignment branch from 7480f09 to 5b9e7d4 Compare July 25, 2019 11:31
@repomaa repomaa force-pushed the topic/transaction_assignment branch from 5b9e7d4 to 0a154fd Compare July 26, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfaust vladfaust vladfaust requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Repository#db=(DB::Transaction)
2 participants
@repomaa @vladfaust