Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] data missing for quickstart #90

Closed
wipfli opened this issue Feb 24, 2022 · 2 comments · Fixed by #93
Closed

[BUG] data missing for quickstart #90

wipfli opened this issue Feb 24, 2022 · 2 comments · Fixed by #93

Comments

@wipfli
Copy link
Contributor

wipfli commented Feb 24, 2022

Describe the bug

The quickstart-from-source.sh script does not download data.

To Reproduce
Steps to reproduce the behavior:

  1. clone this repo
  2. configure java and intellij according to contributing guidelines
  3. run ./quickstart-from-source.sh
  4. Error Exception in thread "main" java.lang.IllegalArgumentException: data/sources/lake_centerline.shp.zip does not exist

Expected behavior
quickstart-from-souce.sh should download the required assets.

Environment (please complete the following information):

  • Hardware: dell xps 2021
  • OS: ubuntu
  • Java version and distribution: java 17.0.1 2021-10-19 LTS
@wipfli
Copy link
Contributor Author

wipfli commented Feb 24, 2022

Maybe we could add instructions somewhere that one needs to download the stuff first with something like:

sudo docker run -e JAVA_TOOL_OPTIONS="-Xmx1g" -v "$(pwd)/data":/data ghcr.io/onthegomap/planetiler:latest --only-download --area=monaco

@msbarry
Copy link
Contributor

msbarry commented Feb 25, 2022

Good catch! We'll add some more scripts for different run variations (docker/jar/maven) in #74 but for now I think all that might be needed is adding the --download option here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants