ginkgo: fix data race #1624
Merged
ginkgo: fix data race #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write at 0x00c000368528 by goroutine 25:
os/exec.(*Cmd).Wait()
os/exec/exec.go:926 +0x1a4
github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func2()
github.com/onsi/ginkgo/v2@v2.27.2/ginkgo/internal/run.go:231 +0x37
Previous read at 0x00c000368528 by goroutine 96714:
github.com/onsi/ginkgo/v2/ginkgo/internal.runParallel.func1()
github.com/onsi/ginkgo/v2@v2.27.2/ginkgo/internal/run.go:228 +0x3b
github.com/onsi/ginkgo/v2/internal/parallel_support.(*ServerHandler).procIsAlive()
github.com/onsi/ginkgo/v2@v2.27.2/internal/parallel_support/server_handler.go:133 +0x121
The problem is that cmd.ProcessState is not thread-safe. The solution is an
atomic bool which gets checked instead and which is written once when the
goroutine waiting for the command has determined that the command has exited.
Owner
|
perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that cmd.ProcessState is not thread-safe. The solution is an atomic bool which gets checked instead and which is written once when the goroutine waiting for the command has determined that the command has exited.