Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix current contribution flow #496

Closed
nodo opened this issue Jul 4, 2018 · 2 comments
Closed

Fix current contribution flow #496

nodo opened this issue Jul 4, 2018 · 2 comments

Comments

@nodo
Copy link
Collaborator

nodo commented Jul 4, 2018

The current flow for contributions if the following:

  1. Fork ginkgo
  2. Install gomega
  3. cd $GOPATH/src/github.com/USERNAME && git clone git@github.com:USERNAME/ginkgo.git
  4. AWESOME CODING
  5. ./before_pr.sh
  6. Run ginkgo -r
  7. Open a PR if tests are all green

However, when running the tests I see:

Summarizing 1 Failure:

[Fail] Coverage Specs when it runs coverage analysis in series and in parallel [It] works
/Users/andreanodari/go/src/github.com/nodo/ginkgo/integration/coverage_test.go:23

Ran 119 of 119 Specs in 262.852 seconds

And in particular the tests fails because the coverage is not correct:

Got stuck at:
      Running Suite: CoverageFixture Suite
      ====================================
      Random Seed: 1530691030
      Will run 5 of 5 specs

      •••••
      Ran 5 of 5 Specs in 0.000 seconds
      SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 0 Skipped
      PASS
      coverage: 0.0% of statements

      Ginkgo ran 1 suite in 1.39062547s
      Test Suite Passed

  Waiting for:
      coverage: 80.0% of statements

I think this happens because the fixtures and the tests are not properly changed by the script (see for instance these imports).

@nodo
Copy link
Collaborator Author

nodo commented Jul 12, 2018

See #494 (comment)

@nodo
Copy link
Collaborator Author

nodo commented Jul 13, 2018

Fixed in #494

@nodo nodo closed this as completed Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant