#98 Change insertion position name

Author: onozaty

app/models/view_customize.rb

@@ -22,14 +22,14 @@ class ViewCustomize < ActiveRecord::Base
   INSERTION_POSITION_HTML_BOTTOM = "html_bottom"
   INSERTION_POSITION_ISSUE_FORM = "issue_form"
   INSERTION_POSITION_ISSUE_SHOW = "issue_show"
-  INSERTION_POSITION_CONTEXT_MENU_END = "context_menu_end"
+  INSERTION_POSITION_ISSUES_CONTEXT_MENU = "issues_context_menu"
 
   @@insertion_positions = {
     :label_insertion_position_html_head => INSERTION_POSITION_HTML_HEAD,
     :label_insertion_position_issue_form => INSERTION_POSITION_ISSUE_FORM,
     :label_insertion_position_issue_show => INSERTION_POSITION_ISSUE_SHOW,
     :label_insertion_position_html_bottom => INSERTION_POSITION_HTML_BOTTOM,
-    :label_insertion_position_context_menu_end => INSERTION_POSITION_CONTEXT_MENU_END
+    :label_insertion_position_issues_context_menu => INSERTION_POSITION_ISSUES_CONTEXT_MENU
   }
 
   def customize_types

config/locales/en.yml

@@ -11,7 +11,7 @@ en:
   label_insertion_position_html_bottom: "Bottom of all pages"
   label_insertion_position_issue_form: "Bottom of issue form"
   label_insertion_position_issue_show: "Bottom of issue detail"
-  label_insertion_position_context_menu_end: "End of context menu"
+  label_insertion_position_issues_context_menu: "Issues context menu"
   field_path_pattern: "Path pattern"
   field_project_pattern: "Project pattern"
   field_insertion_position: "Insertion position"

config/locales/ja.yml

@@ -11,6 +11,7 @@ ja:
   label_insertion_position_html_bottom: "全ページの末尾"
   label_insertion_position_issue_form: "チケット入力欄の下"
   label_insertion_position_issue_show: "チケット詳細の下"
+  label_insertion_position_issues_context_menu: "チケット一覧のコンテキストメニュー"
   field_path_pattern: "パスのパターン"
   field_project_pattern: "プロジェクトのパターン"
   field_insertion_position: "挿入位置"

config/locales/zh-TW.yml

@@ -11,6 +11,7 @@ zh-TW:
   label_insertion_position_html_bottom: "所有頁面的底部"
   label_insertion_position_issue_form: "議題清單底部"
   label_insertion_position_issue_show: "議題詳情頁面"
+  label_insertion_position_issues_context_menu: "議題上下文菜單"
   field_path_pattern: "路徑表達式"
   field_project_pattern: "專案表達式"
   field_insertion_position: "嵌入位置"

config/locales/zh.yml

@@ -11,6 +11,7 @@ zh:
   label_insertion_position_html_bottom: "所有页面的底部"
   label_insertion_position_issue_form: "问题(issue)表单底部"
   label_insertion_position_issue_show: "问题(issue)详情页面"
+  label_insertion_position_issues_context_menu: "问题(issue)上下文菜单"
   field_path_pattern: "路径表达式"
   field_project_pattern: "项目表达式"
   field_insertion_position: "嵌入位置"

lib/redmine_view_customize/view_hook.rb

@@ -52,7 +52,7 @@ def view_issues_show_details_bottom(context={})
     end
 
     def view_issues_context_menu_end(context={})
-      return "\n" + create_view_customize_html(context, ViewCustomize::INSERTION_POSITION_CONTEXT_MENU_END)
+      return "\n" + create_view_customize_html(context, ViewCustomize::INSERTION_POSITION_ISSUES_CONTEXT_MENU)
     end 
 
     private

test/fixtures/view_customizes.yml

@@ -104,7 +104,7 @@ view_customize_010:
   is_enabled: true
   is_private: false
   author_id: 1
-  insertion_position: context_menu_end
+  insertion_position: issues_context_menu
   customize_type: javascript
   comments: comment_010
   project_pattern: ""