Skip to content

Commit 2a796d8

Browse files
committed
btrfs-progs: replace leafsize with nodesize
Nodesize is used in kernel, the values are always equal. We have to keep leafsize in headers, similarly the tree setting functions still take and set leafsize, but it's effectively a no-op. Signed-off-by: David Sterba <dsterba@suse.com>
1 parent b005ca0 commit 2a796d8

17 files changed

+88
-89
lines changed

backref.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ static int __add_missing_keys(struct btrfs_fs_info *fs_info,
451451
continue;
452452
BUG_ON(!ref->wanted_disk_byte);
453453
eb = read_tree_block(fs_info->tree_root, ref->wanted_disk_byte,
454-
fs_info->tree_root->leafsize, 0);
454+
fs_info->tree_root->nodesize, 0);
455455
if (!extent_buffer_uptodate(eb)) {
456456
free_extent_buffer(eb);
457457
return -EIO;
@@ -1157,7 +1157,7 @@ int extent_from_logical(struct btrfs_fs_info *fs_info, u64 logical,
11571157
}
11581158
btrfs_item_key_to_cpu(path->nodes[0], found_key, path->slots[0]);
11591159
if (found_key->type == BTRFS_METADATA_ITEM_KEY)
1160-
size = fs_info->extent_root->leafsize;
1160+
size = fs_info->extent_root->nodesize;
11611161
else if (found_key->type == BTRFS_EXTENT_ITEM_KEY)
11621162
size = found_key->offset;
11631163

btrfs-corrupt-block.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ static int corrupt_keys_in_block(struct btrfs_root *root, u64 bytenr)
162162
{
163163
struct extent_buffer *eb;
164164

165-
eb = read_tree_block(root, bytenr, root->leafsize, 0);
165+
eb = read_tree_block(root, bytenr, root->nodesize, 0);
166166
if (!extent_buffer_uptodate(eb))
167167
return -EIO;;
168168

@@ -289,7 +289,7 @@ static void btrfs_corrupt_extent_tree(struct btrfs_trans_handle *trans,
289289
struct extent_buffer *next;
290290

291291
next = read_tree_block(root, btrfs_node_blockptr(eb, i),
292-
root->leafsize,
292+
root->nodesize,
293293
btrfs_node_ptr_generation(eb, i));
294294
if (!extent_buffer_uptodate(next))
295295
continue;
@@ -700,7 +700,7 @@ static int corrupt_metadata_block(struct btrfs_root *root, u64 block,
700700
return -EINVAL;
701701
}
702702

703-
eb = read_tree_block(root, block, root->leafsize, 0);
703+
eb = read_tree_block(root, block, root->nodesize, 0);
704704
if (!extent_buffer_uptodate(eb)) {
705705
fprintf(stderr, "Couldn't read in tree block %s\n", field);
706706
return -EINVAL;

btrfs-image.c

+19-21
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ struct mdrestore_struct {
133133
struct list_head list;
134134
struct list_head overlapping_chunks;
135135
size_t num_items;
136-
u32 leafsize;
136+
u32 nodesize;
137137
u64 devid;
138138
u64 alloced_chunks;
139139
u64 last_physical_offset;
@@ -1073,7 +1073,7 @@ static int copy_tree_blocks(struct btrfs_root *root, struct extent_buffer *eb,
10731073
int i = 0;
10741074
int ret;
10751075

1076-
ret = add_extent(btrfs_header_bytenr(eb), root->leafsize, metadump, 0);
1076+
ret = add_extent(btrfs_header_bytenr(eb), root->nodesize, metadump, 0);
10771077
if (ret) {
10781078
fprintf(stderr, "Error adding metadata block\n");
10791079
return ret;
@@ -1091,7 +1091,7 @@ static int copy_tree_blocks(struct btrfs_root *root, struct extent_buffer *eb,
10911091
continue;
10921092
ri = btrfs_item_ptr(eb, i, struct btrfs_root_item);
10931093
bytenr = btrfs_disk_root_bytenr(eb, ri);
1094-
tmp = read_tree_block(root, bytenr, root->leafsize, 0);
1094+
tmp = read_tree_block(root, bytenr, root->nodesize, 0);
10951095
if (!extent_buffer_uptodate(tmp)) {
10961096
fprintf(stderr,
10971097
"Error reading log root block\n");
@@ -1103,7 +1103,7 @@ static int copy_tree_blocks(struct btrfs_root *root, struct extent_buffer *eb,
11031103
return ret;
11041104
} else {
11051105
bytenr = btrfs_node_blockptr(eb, i);
1106-
tmp = read_tree_block(root, bytenr, root->leafsize, 0);
1106+
tmp = read_tree_block(root, bytenr, root->nodesize, 0);
11071107
if (!extent_buffer_uptodate(tmp)) {
11081108
fprintf(stderr, "Error reading log block\n");
11091109
return -EIO;
@@ -1255,7 +1255,7 @@ static int copy_from_extent_tree(struct metadump_struct *metadump,
12551255

12561256
bytenr = key.objectid;
12571257
if (key.type == BTRFS_METADATA_ITEM_KEY)
1258-
num_bytes = extent_root->leafsize;
1258+
num_bytes = extent_root->nodesize;
12591259
else
12601260
num_bytes = key.offset;
12611261

@@ -1321,8 +1321,6 @@ static int create_metadump(const char *input, FILE *out, int num_threads,
13211321
return -EIO;
13221322
}
13231323

1324-
BUG_ON(root->nodesize != root->leafsize);
1325-
13261324
ret = metadump_init(&metadump, root, out, num_threads,
13271325
compress_level, sanitize);
13281326
if (ret) {
@@ -1550,16 +1548,16 @@ static int fixup_chunk_tree_block(struct mdrestore_struct *mdres,
15501548
u64 bytenr = async->start;
15511549
int i;
15521550

1553-
if (size_left % mdres->leafsize)
1551+
if (size_left % mdres->nodesize)
15541552
return 0;
15551553

1556-
eb = alloc_dummy_eb(bytenr, mdres->leafsize);
1554+
eb = alloc_dummy_eb(bytenr, mdres->nodesize);
15571555
if (!eb)
15581556
return -ENOMEM;
15591557

15601558
while (size_left) {
15611559
eb->start = bytenr;
1562-
memcpy(eb->data, buffer, mdres->leafsize);
1560+
memcpy(eb->data, buffer, mdres->nodesize);
15631561

15641562
if (btrfs_header_bytenr(eb) != bytenr)
15651563
break;
@@ -1614,9 +1612,9 @@ static int fixup_chunk_tree_block(struct mdrestore_struct *mdres,
16141612
memcpy(buffer, eb->data, eb->len);
16151613
csum_block(buffer, eb->len);
16161614
next:
1617-
size_left -= mdres->leafsize;
1618-
buffer += mdres->leafsize;
1619-
bytenr += mdres->leafsize;
1615+
size_left -= mdres->nodesize;
1616+
buffer += mdres->nodesize;
1617+
bytenr += mdres->nodesize;
16201618
}
16211619

16221620
free(eb);
@@ -1687,7 +1685,7 @@ static void *restore_worker(void *data)
16871685
int err = 0;
16881686

16891687
pthread_mutex_lock(&mdres->mutex);
1690-
while (!mdres->leafsize || list_empty(&mdres->list)) {
1688+
while (!mdres->nodesize || list_empty(&mdres->list)) {
16911689
if (mdres->done) {
16921690
pthread_mutex_unlock(&mdres->mutex);
16931691
goto out;
@@ -1859,7 +1857,7 @@ static int fill_mdres_info(struct mdrestore_struct *mdres,
18591857
int ret;
18601858

18611859
/* We've already been initialized */
1862-
if (mdres->leafsize)
1860+
if (mdres->nodesize)
18631861
return 0;
18641862

18651863
if (mdres->compress_method == COMPRESS_ZLIB) {
@@ -1881,7 +1879,7 @@ static int fill_mdres_info(struct mdrestore_struct *mdres,
18811879
}
18821880

18831881
super = (struct btrfs_super_block *)outbuf;
1884-
mdres->leafsize = btrfs_super_leafsize(super);
1882+
mdres->nodesize = btrfs_super_nodesize(super);
18851883
memcpy(mdres->fsid, super->fsid, BTRFS_FSID_SIZE);
18861884
memcpy(mdres->uuid, super->dev_item.uuid,
18871885
BTRFS_UUID_SIZE);
@@ -1987,18 +1985,18 @@ static int read_chunk_block(struct mdrestore_struct *mdres, u8 *buffer,
19871985
int ret = 0;
19881986
int i;
19891987

1990-
eb = alloc_dummy_eb(bytenr, mdres->leafsize);
1988+
eb = alloc_dummy_eb(bytenr, mdres->nodesize);
19911989
if (!eb) {
19921990
ret = -ENOMEM;
19931991
goto out;
19941992
}
19951993

19961994
while (item_bytenr != bytenr) {
1997-
buffer += mdres->leafsize;
1998-
item_bytenr += mdres->leafsize;
1995+
buffer += mdres->nodesize;
1996+
item_bytenr += mdres->nodesize;
19991997
}
20001998

2001-
memcpy(eb->data, buffer, mdres->leafsize);
1999+
memcpy(eb->data, buffer, mdres->nodesize);
20022000
if (btrfs_header_bytenr(eb) != bytenr) {
20032001
fprintf(stderr, "Eb bytenr doesn't match found bytenr\n");
20042002
ret = -EIO;
@@ -2301,7 +2299,7 @@ static int build_chunk_tree(struct mdrestore_struct *mdres,
23012299
pthread_mutex_lock(&mdres->mutex);
23022300
super = (struct btrfs_super_block *)buffer;
23032301
chunk_root_bytenr = btrfs_super_chunk_root(super);
2304-
mdres->leafsize = btrfs_super_leafsize(super);
2302+
mdres->nodesize = btrfs_super_nodesize(super);
23052303
memcpy(mdres->fsid, super->fsid, BTRFS_FSID_SIZE);
23062304
memcpy(mdres->uuid, super->dev_item.uuid,
23072305
BTRFS_UUID_SIZE);

btrfs-map-logical.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ static int map_one_extent(struct btrfs_fs_info *fs_info,
8181
}
8282
logical = key.objectid;
8383
if (key.type == BTRFS_METADATA_ITEM_KEY)
84-
len = fs_info->tree_root->leafsize;
84+
len = fs_info->tree_root->nodesize;
8585
else
8686
len = key.offset;
8787

chunk-recover.c

+9-9
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ struct recover_control {
4747

4848
u16 csum_size;
4949
u32 sectorsize;
50-
u32 leafsize;
50+
u32 nodesize;
5151
u64 generation;
5252
u64 chunk_root_generation;
5353

@@ -477,7 +477,7 @@ static void print_scan_result(struct recover_control *rc)
477477
printf("DEVICE SCAN RESULT:\n");
478478
printf("Filesystem Information:\n");
479479
printf("\tsectorsize: %d\n", rc->sectorsize);
480-
printf("\tleafsize: %d\n", rc->leafsize);
480+
printf("\tnodesize: %d\n", rc->nodesize);
481481
printf("\ttree root generation: %llu\n", rc->generation);
482482
printf("\tchunk root generation: %llu\n", rc->chunk_root_generation);
483483
printf("\n");
@@ -761,10 +761,10 @@ static int scan_one_device(void *dev_scan_struct)
761761
if (ret)
762762
return 1;
763763

764-
buf = malloc(sizeof(*buf) + rc->leafsize);
764+
buf = malloc(sizeof(*buf) + rc->nodesize);
765765
if (!buf)
766766
return -ENOMEM;
767-
buf->len = rc->leafsize;
767+
buf->len = rc->nodesize;
768768

769769
bytenr = 0;
770770
while (1) {
@@ -773,8 +773,8 @@ static int scan_one_device(void *dev_scan_struct)
773773
if (is_super_block_address(bytenr))
774774
bytenr += rc->sectorsize;
775775

776-
if (pread64(fd, buf->data, rc->leafsize, bytenr) <
777-
rc->leafsize)
776+
if (pread64(fd, buf->data, rc->nodesize, bytenr) <
777+
rc->nodesize)
778778
break;
779779

780780
if (memcmp_extent_buffer(buf, rc->fs_devices->fsid,
@@ -818,7 +818,7 @@ static int scan_one_device(void *dev_scan_struct)
818818
break;
819819
}
820820
next_node:
821-
bytenr += rc->leafsize;
821+
bytenr += rc->nodesize;
822822
}
823823
out:
824824
close(fd);
@@ -1070,7 +1070,7 @@ static int block_group_remove_all_extent_items(struct btrfs_trans_handle *trans,
10701070
key.type == BTRFS_METADATA_ITEM_KEY) {
10711071
old_val = btrfs_super_bytes_used(fs_info->super_copy);
10721072
if (key.type == BTRFS_METADATA_ITEM_KEY)
1073-
old_val += root->leafsize;
1073+
old_val += root->nodesize;
10741074
else
10751075
old_val += key.offset;
10761076
btrfs_set_super_bytes_used(fs_info->super_copy,
@@ -1538,7 +1538,7 @@ static int recover_prepare(struct recover_control *rc, char *path)
15381538
}
15391539

15401540
rc->sectorsize = btrfs_super_sectorsize(sb);
1541-
rc->leafsize = btrfs_super_leafsize(sb);
1541+
rc->nodesize = btrfs_super_nodesize(sb);
15421542
rc->generation = btrfs_super_generation(sb);
15431543
rc->chunk_root_generation = btrfs_super_chunk_root_generation(sb);
15441544
rc->csum_size = btrfs_super_csum_size(sb);

cmds-check.c

+11-11
Original file line numberDiff line numberDiff line change
@@ -1890,7 +1890,7 @@ static int walk_down_tree(struct btrfs_root *root, struct btrfs_path *path,
18901890
btrfs_add_corrupt_extent_record(root->fs_info,
18911891
&node_key,
18921892
path->nodes[*level]->start,
1893-
root->leafsize, *level);
1893+
root->nodesize, *level);
18941894
err = -EIO;
18951895
goto out;
18961896
}
@@ -5187,7 +5187,7 @@ static int process_extent_item(struct btrfs_root *root,
51875187

51885188
if (key.type == BTRFS_METADATA_ITEM_KEY) {
51895189
metadata = 1;
5190-
num_bytes = root->leafsize;
5190+
num_bytes = root->nodesize;
51915191
} else {
51925192
num_bytes = key.offset;
51935193
}
@@ -5407,7 +5407,7 @@ static int verify_space_cache(struct btrfs_root *root,
54075407
if (key.type == BTRFS_EXTENT_ITEM_KEY)
54085408
last = key.objectid + key.offset;
54095409
else
5410-
last = key.objectid + root->leafsize;
5410+
last = key.objectid + root->nodesize;
54115411
path->slots[0]++;
54125412
continue;
54135413
}
@@ -5419,7 +5419,7 @@ static int verify_space_cache(struct btrfs_root *root,
54195419
if (key.type == BTRFS_EXTENT_ITEM_KEY)
54205420
last = key.objectid + key.offset;
54215421
else
5422-
last = key.objectid + root->leafsize;
5422+
last = key.objectid + root->nodesize;
54235423
path->slots[0]++;
54245424
}
54255425

@@ -6379,7 +6379,7 @@ static int delete_extent_records(struct btrfs_trans_handle *trans,
63796379
if (found_key.type == BTRFS_EXTENT_ITEM_KEY ||
63806380
found_key.type == BTRFS_METADATA_ITEM_KEY) {
63816381
u64 bytes = (found_key.type == BTRFS_EXTENT_ITEM_KEY) ?
6382-
found_key.offset : root->leafsize;
6382+
found_key.offset : root->nodesize;
63836383

63846384
ret = btrfs_update_block_group(trans, root, bytenr,
63856385
bytes, 0, 0);
@@ -6414,7 +6414,7 @@ static int record_extent(struct btrfs_trans_handle *trans,
64146414

64156415
if (!back->is_data)
64166416
rec->max_size = max_t(u64, rec->max_size,
6417-
info->extent_root->leafsize);
6417+
info->extent_root->nodesize);
64186418

64196419
if (!allocated) {
64206420
u32 item_size = sizeof(*ei);
@@ -8421,7 +8421,7 @@ static int pin_down_tree_blocks(struct btrfs_fs_info *fs_info,
84218421
struct btrfs_root_item *ri;
84228422
struct btrfs_key key;
84238423
u64 bytenr;
8424-
u32 leafsize;
8424+
u32 nodesize;
84258425
int level = btrfs_header_level(eb);
84268426
int nritems;
84278427
int ret;
@@ -8438,7 +8438,7 @@ static int pin_down_tree_blocks(struct btrfs_fs_info *fs_info,
84388438

84398439
btrfs_pin_extent(fs_info, eb->start, eb->len);
84408440

8441-
leafsize = btrfs_super_leafsize(fs_info->super_copy);
8441+
nodesize = btrfs_super_nodesize(fs_info->super_copy);
84428442
nritems = btrfs_header_nritems(eb);
84438443
for (i = 0; i < nritems; i++) {
84448444
if (level == 0) {
@@ -8460,7 +8460,7 @@ static int pin_down_tree_blocks(struct btrfs_fs_info *fs_info,
84608460
* just pass in extent_root.
84618461
*/
84628462
tmp = read_tree_block(fs_info->extent_root, bytenr,
8463-
leafsize, 0);
8463+
nodesize, 0);
84648464
if (!extent_buffer_uptodate(tmp)) {
84658465
fprintf(stderr, "Error reading root block\n");
84668466
return -EIO;
@@ -8474,12 +8474,12 @@ static int pin_down_tree_blocks(struct btrfs_fs_info *fs_info,
84748474

84758475
/* If we aren't the tree root don't read the block */
84768476
if (level == 1 && !tree_root) {
8477-
btrfs_pin_extent(fs_info, bytenr, leafsize);
8477+
btrfs_pin_extent(fs_info, bytenr, nodesize);
84788478
continue;
84798479
}
84808480

84818481
tmp = read_tree_block(fs_info->extent_root, bytenr,
8482-
leafsize, 0);
8482+
nodesize, 0);
84838483
if (!extent_buffer_uptodate(tmp)) {
84848484
fprintf(stderr, "Error reading tree block\n");
84858485
return -EIO;

cmds-inspect-dump-tree.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ int cmd_inspect_dump_tree(int argc, char **argv)
299299
if (block_only) {
300300
leaf = read_tree_block(root,
301301
block_only,
302-
root->leafsize, 0);
302+
root->nodesize, 0);
303303

304304
if (extent_buffer_uptodate(leaf) &&
305305
btrfs_header_level(leaf) != 0) {

0 commit comments

Comments
 (0)