Skip to content

Commit 0445740

Browse files
committed
updated debug log message and make it more readable
1 parent 8652185 commit 0445740

File tree

1 file changed

+27
-26
lines changed

1 file changed

+27
-26
lines changed

ngx_http_proxy_connect_module.c

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ ngx_http_proxy_connect_finalize_request(ngx_http_request_t *r,
411411
ngx_http_proxy_connect_upstream_t *u, ngx_int_t rc)
412412
{
413413
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
414-
"finalize proxy_conncet upstream request: %i", rc);
414+
"proxy_connect: finalize upstream request: %i", rc);
415415

416416
r->keepalive = 0;
417417

@@ -428,7 +428,7 @@ ngx_http_proxy_connect_finalize_request(ngx_http_request_t *r,
428428
if (u->peer.connection) {
429429

430430
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
431-
"close proxy_connect upstream connection: %d",
431+
"proxy_connect: close upstream connection: %d",
432432
u->peer.connection->fd);
433433

434434
if (u->peer.connection->pool) {
@@ -475,7 +475,7 @@ ngx_http_proxy_connect_send_connection_established(ngx_http_request_t *r)
475475
c = r->connection;
476476

477477
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
478-
"proxy_connect send 200 connection established");
478+
"proxy_connect: send 200 connection established");
479479

480480
clcf = ngx_http_get_module_loc_conf(r, ngx_http_core_module);
481481

@@ -497,7 +497,7 @@ ngx_http_proxy_connect_send_connection_established(ngx_http_request_t *r)
497497

498498
if (b->pos == b->last) {
499499
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, c->log, 0,
500-
"proxy_connect sent 200 connection established");
500+
"proxy_connect: sent 200 connection established");
501501

502502
if (c->write->timer_set) {
503503
ngx_del_timer(c->write);
@@ -571,7 +571,7 @@ ngx_http_proxy_connect_tunnel(ngx_http_request_t *r,
571571
u = ctx->u;
572572

573573
ngx_log_debug2(NGX_LOG_DEBUG_HTTP, c->log, 0,
574-
"http proxy_connect, fu:%ui write:%ui",
574+
"proxy_connect: tunnel fu:%ui write:%ui",
575575
from_upstream, do_write);
576576

577577
downstream = c;
@@ -667,7 +667,7 @@ ngx_http_proxy_connect_tunnel(ngx_http_request_t *r,
667667
|| (downstream->read->eof && upstream->read->eof))
668668
{
669669
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, c->log, 0,
670-
"http proxy_connect done");
670+
"proxy_connect: tunnel done");
671671
ngx_http_proxy_connect_finalize_request(r, u, 0);
672672
return;
673673
}
@@ -780,7 +780,7 @@ ngx_http_proxy_connect_read_upstream(ngx_http_request_t *r,
780780
ngx_http_proxy_connect_ctx_t *ctx;
781781

782782
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
783-
"proxy_connect upstream read handler");
783+
"proxy_connect: upstream read handler");
784784

785785
ctx = ngx_http_get_module_ctx(r, ngx_http_proxy_connect_module);
786786

@@ -839,7 +839,7 @@ ngx_http_proxy_connect_write_upstream(ngx_http_request_t *r,
839839
c = u->peer.connection;
840840

841841
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
842-
"proxy_connect upstream write handler");
842+
"proxy_connect: upstream write handler");
843843

844844
if (c->write->timedout) {
845845
ngx_log_error(NGX_LOG_ERR, c->log, 0,
@@ -892,7 +892,7 @@ ngx_http_proxy_connect_send_handler(ngx_http_request_t *r)
892892
ctx = ngx_http_get_module_ctx(r, ngx_http_proxy_connect_module);
893893

894894
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
895-
"proxy_connect send connection established handler");
895+
"proxy_connect: send connection established handler");
896896

897897
if (c->write->timedout) {
898898
c->timedout = 1;
@@ -927,7 +927,7 @@ ngx_http_proxy_connect_upstream_handler(ngx_event_t *ev)
927927
lctx->current_request = r;
928928

929929
ngx_log_debug2(NGX_LOG_DEBUG_HTTP, c->log, 0,
930-
"http proxy_connect upstream handler: \"%V:%V\"",
930+
"proxy_connect: upstream handler: \"%V:%V\"",
931931
&r->connect_host, &r->connect_port);
932932

933933
if (ev->write) {
@@ -972,7 +972,7 @@ ngx_http_proxy_connect_process_connect(ngx_http_request_t *r,
972972
rc = ngx_event_connect_peer(&u->peer);
973973

974974
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
975-
"proxy_connect upstream connect: %i", rc);
975+
"proxy_connect: ngx_event_connect_peer() returns %i", rc);
976976

977977
if (rc == NGX_ERROR) {
978978
ngx_http_proxy_connect_finalize_request(r, u,
@@ -1050,7 +1050,7 @@ ngx_http_proxy_connect_resolve_handler(ngx_resolver_ctx_t *ctx)
10501050
c = r->connection;
10511051

10521052
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
1053-
"proxy_connect resolve handler");
1053+
"proxy_connect: resolve handler");
10541054

10551055
if (ctx->state) {
10561056
ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
@@ -1079,7 +1079,7 @@ ngx_http_proxy_connect_resolve_handler(ngx_resolver_ctx_t *ctx)
10791079
text, NGX_SOCKADDR_STRLEN, 0);
10801080

10811081
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
1082-
"name was resolved to %V", &addr);
1082+
"proxy_connect: name was resolved to %V", &addr);
10831083
}
10841084
# else
10851085
ngx_uint_t i;
@@ -1089,7 +1089,7 @@ ngx_http_proxy_connect_resolve_handler(ngx_resolver_ctx_t *ctx)
10891089
addr = ntohl(ctx->addrs[i]);
10901090

10911091
ngx_log_debug4(NGX_LOG_DEBUG_HTTP, c->log, 0,
1092-
"name was resolved to %ud.%ud.%ud.%ud",
1092+
"proxy_connect: name was resolved to %ud.%ud.%ud.%ud",
10931093
(addr >> 24) & 0xff, (addr >> 16) & 0xff,
10941094
(addr >> 8) & 0xff, addr & 0xff);
10951095
}
@@ -1221,7 +1221,7 @@ ngx_http_proxy_connect_check_broken_connection(ngx_http_request_t *r,
12211221
ngx_http_proxy_connect_upstream_t *u;
12221222

12231223
ngx_log_debug3(NGX_LOG_DEBUG_HTTP, ev->log, 0,
1224-
"http proxy_connect check client, write event:%d, \"%V:%V\"",
1224+
"proxy_connect: check client, write event:%d, \"%V:%V\"",
12251225
ev->write, &r->connect_host, &r->connect_port);
12261226

12271227
c = r->connection;
@@ -1263,16 +1263,17 @@ ngx_http_proxy_connect_check_broken_connection(ngx_http_request_t *r,
12631263

12641264
if (u->peer.connection) {
12651265
ngx_log_error(NGX_LOG_INFO, ev->log, ev->kq_errno,
1266-
"kevent() reported that client prematurely closed "
1267-
"connection, so upstream connection is closed too");
1266+
"proxy_connect: kevent() reported that client "
1267+
"prematurely closed connection, so upstream "
1268+
" connection is closed too");
12681269
ngx_http_proxy_connect_finalize_request(r, u,
12691270
NGX_HTTP_CLIENT_CLOSED_REQUEST);
12701271
return;
12711272
}
12721273

12731274
ngx_log_error(NGX_LOG_INFO, ev->log, ev->kq_errno,
1274-
"kevent() reported that client prematurely closed "
1275-
"connection");
1275+
"proxy_connect: kevent() reported that client "
1276+
"prematurely closed connection");
12761277

12771278
if (u->peer.connection == NULL) {
12781279
ngx_http_proxy_connect_finalize_request(r, u,
@@ -1289,7 +1290,7 @@ ngx_http_proxy_connect_check_broken_connection(ngx_http_request_t *r,
12891290
err = ngx_socket_errno;
12901291

12911292
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, ev->log, err,
1292-
"http proxy_connect upstream recv(): %d", n);
1293+
"proxy_connect: upstream recv(): %d", n);
12931294

12941295
if (ev->write && (n >= 0 || err == NGX_EAGAIN)) {
12951296
return;
@@ -1326,15 +1327,15 @@ ngx_http_proxy_connect_check_broken_connection(ngx_http_request_t *r,
13261327

13271328
if (u->peer.connection) {
13281329
ngx_log_error(NGX_LOG_INFO, ev->log, err,
1329-
"client prematurely closed connection, "
1330+
"proxy_connect: client prematurely closed connection, "
13301331
"so upstream connection is closed too");
13311332
ngx_http_proxy_connect_finalize_request(r, u,
13321333
NGX_HTTP_CLIENT_CLOSED_REQUEST);
13331334
return;
13341335
}
13351336

13361337
ngx_log_error(NGX_LOG_INFO, ev->log, err,
1337-
"client prematurely closed connection");
1338+
"proxy_connect: client prematurely closed connection");
13381339

13391340
if (u->peer.connection == NULL) {
13401341
ngx_http_proxy_connect_finalize_request(r, u,
@@ -1411,7 +1412,7 @@ ngx_http_proxy_connect_handler(ngx_http_request_t *r)
14111412
url.no_resolve = 1;
14121413

14131414
ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
1414-
"connect handler: parse url: %V" , &url.url);
1415+
"proxy_connect: connect handler: parse url: %V" , &url.url);
14151416

14161417
if (ngx_parse_url(r->pool, &url) != NGX_OK) {
14171418
if (url.err) {
@@ -1441,7 +1442,7 @@ ngx_http_proxy_connect_handler(ngx_http_request_t *r)
14411442

14421443
if (url.addrs) {
14431444
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
1444-
"connect network address given directly");
1445+
"proxy_connect: upstream address given directly");
14451446

14461447
u->resolved->sockaddr = url.addrs[0].sockaddr;
14471448
u->resolved->socklen = url.addrs[0].socklen;
@@ -1503,7 +1504,7 @@ ngx_http_proxy_connect_handler(ngx_http_request_t *r)
15031504

15041505
if (ngx_resolve_name(rctx) != NGX_OK) {
15051506
ngx_log_debug0(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
1506-
"proxy_connect fail to run resolver immediately");
1507+
"proxy_connect: fail to run resolver immediately");
15071508

15081509
u->resolved->ctx = NULL;
15091510
r->main->count--;
@@ -2021,7 +2022,7 @@ ngx_http_proxy_connect_post_read_handler(ngx_http_request_t *r)
20212022

20222023
if (!pclcf->accept_connect) {
20232024
ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
2024-
"client sent connect method");
2025+
"proxy_connect: client sent connect method");
20252026
return NGX_HTTP_BAD_REQUEST;
20262027
}
20272028

0 commit comments

Comments
 (0)