[Access] Adjust logging in checkpoint loading #4797
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
+ Coverage 55.82% 65.52% +9.69%
==========================================
Files 939 192 -747
Lines 86905 20010 -66895
==========================================
- Hits 48513 13111 -35402
+ Misses 34739 5927 -28812
+ Partials 3653 972 -2681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| batch := b.db.NewBatch() | ||
| defer batch.Close() | ||
|
|
||
| b.log.Trace().Int("batch_size", len(leafNodes)).Msg("indexing batch of leaf nodes") |
There was a problem hiding this comment.
I believe this is to monitor the progress.
Actually, OpenAndReadLeafNodesFromCheckpointV6 is already doing that, since it's logging the percentage of reading the trie, and is blocked if database is not storing the registers fast enough, which means if the log shows the reading percentage is going up, it means leaf nodes are being indexed properly.
There was a problem hiding this comment.
yea, exactly. the checkpoint loader also logs based on % progress, resulting in much fewer messages
The
indexing batch of leaf nodesmessage is very noisy and generally not needed.