[v0.29] Backport: Fix OBO and inconsistency in signer indices decoding used in Access API #3906

[jordanschalm]

Backport #3906

[codecov-commenter]

Codecov Report

Merging #3979 (6cf9ba4) into v0.29 (6969403) will decrease coverage by 4.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            v0.29    #3979      +/-   ##
==========================================
- Coverage   53.28%   49.24%   -4.04%     
==========================================
  Files         818      531     -287     
  Lines       76454    50059   -26395     
==========================================
- Hits        40741    24654   -16087     
+ Misses      32403    23279    -9124     
+ Partials     3310     2126    -1184     

Flag	Coverage Δ
unittests	49.24% <ø> (-4.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
module/jobqueue/workerpool.go	86.48% <0.00%> (-8.11%)	⬇️
...nsensus/hotstuff/signature/block_signer_decoder.go
engine/execution/rpc/engine.go
engine/protocol/handler.go
...on/computer/uploader/retryable_uploader_wrapper.go
network/proxy/network.go
consensus/recovery/recover.go
engine/fifoqueue.go
engine/access/rpc/backend/backend_block_details.go
engine/common/requester/engine.go
... and 278 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

FVM Benchstat comparison

This branch with compared with the base branch onflow:v0.29 commit 6969403

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability