Decouple 'Invocation' from the 'Interpreter'

Author: SupunS

interpreter/conversion.go

@@ -25,7 +25,7 @@ import (
 	"github.com/onflow/cadence/errors"
 )
 
-func ByteArrayValueToByteSlice(interpreter *Interpreter, value Value, locationRange LocationRange) ([]byte, error) {
+func ByteArrayValueToByteSlice(context ContainerMutationContext, value Value, locationRange LocationRange) ([]byte, error) {
 	array, ok := value.(*ArrayValue)
 	if !ok {
 		return nil, errors.NewDefaultUserError("value is not an array")
@@ -39,10 +39,10 @@ func ByteArrayValueToByteSlice(interpreter *Interpreter, value Value, locationRa
 
 		var err error
 		array.Iterate(
-			interpreter,
+			context,
 			func(element Value) (resume bool) {
 				var b byte
-				b, err = ByteValueToByte(interpreter, element, locationRange)
+				b, err = ByteValueToByte(context, element, locationRange)
 				if err != nil {
 					return false
 				}

interpreter/interface.go

@@ -251,6 +251,16 @@ type EventContext interface {
 
 var _ EventContext = &Interpreter{}
 
+// InvocationContext is a composite of all contexts, since function invocations
+// can perform various operations, and hence need to provide all possible contexts to it.
+type InvocationContext interface {
+	StorageContext
+	ValueStringContext
+	MemberAccessibleContext
+}
+
+var _ InvocationContext = &Interpreter{}
+
 // NoOpStringContext is the ValueStringContext implementation used in Value.RecursiveString method.
 // Since Value.RecursiveString is a non-mutating operation, it should only need the no-op memory metering
 // and a WithMutationPrevention implementation.

interpreter/interface_test.go

@@ -1131,7 +1131,7 @@ func TestInterpretInterfaceFunctionConditionsInheritance(t *testing.T) {
 			``,
 			func(invocation interpreter.Invocation) interpreter.Value {
 				message := invocation.Arguments[0].MeteredString(
-					invocation.Interpreter,
+					invocation.InvocationContext,
 					interpreter.SeenReferences{},
 					invocation.LocationRange,
 				)