Support placing child at fixed position regardless of scroll state #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onebone
added
feature
This was
linked to
issues
Jan 23, 2022
|
@twist062021 What is this?? |
|
@onebone What currently stops this PR from being merged? |
I was trying to find some edge cases, looks like it has taken too long..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a common use case of collapsing toolbar to place its child at a fixed position, floating buttons, for example.
Previously, the library did not directly let users do it and should have needed to offset components manually with the
scrollYstate. With this change, it is now possible to place it with the new modifierModifier.alignin theCollapsingToolbarScaffoldbody. This is somewhat similar tolayout_gravityproperty in the Jetpack's CollapsingToolbarLayout.Usage example can be found at
ParallaxActivity.ktin the app module.Backwards compatibility
bodyparameter atCollapsingToolbarScaffoldchanges its signature from() -> UnittoCollapsingToolbarScaffoldScope.() -> Unit. Although it is a non-breaking change in general, there might be some use cases where body lambda is initialized somewhere before then passing the lambda to the function which causes type incompatible error.