[DeviceSanitizer] Fix libstdc++ and libc++ mismatch problem #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UR will force link with libstdc++, but in in-tree build, if LLVM is built with libc++, this will cause mismatch problem. So, in such case, we need to build symbolizer.cpp with libc++ abi and link libc++ in.
yingcong-wu
approved these changes
Aug 23, 2024
Contributor
Author
|
Hi @oneapi-src/unified-runtime-maintain, could you please help review this PR? This is an important fix for sanitizer layer and we need this change to be included in v0.10.x release branch. Thanks. |
Contributor
Author
|
The risk of this change is low. It will not introduce any functionality of ABI change. Only fix a build failure and also will not impact syclos part. |
Contributor
Author
|
kindly ping @oneapi-src/unified-runtime-maintain |
omarahmed1111
approved these changes
Aug 26, 2024
Contributor
|
As I understand, this PR doesn't affect intel/llvm but I created a UR bump PR for it here for syncing purposes as it will still need to land there and I didn't want to batch this change with another non |
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Aug 26, 2024
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 6, 2024
…ismatch [DeviceSanitizer] Fix libstdc++ and libc++ mismatch problem
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 9, 2024
…ismatch [DeviceSanitizer] Fix libstdc++ and libc++ mismatch problem
igchor
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 9, 2024
…ismatch [DeviceSanitizer] Fix libstdc++ and libc++ mismatch problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR will force link with libstdc++, but in in-tree build, if LLVM is built with libc++, this will cause mismatch problem. So, in such case, we need to build symbolizer.cpp with libc++ abi and link libc++ in.