[HIP][CUDA][Command-Buffer] Fix Coverity issues in HIP/CUDA command-buffer code #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/coverity_cuda_update
branch
from
0ad5886 to
5c084e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
- Coverage 14.82% 12.51% -2.32%
==========================================
Files 250 239 -11
Lines 36220 35949 -271
Branches 4094 4076 -18
==========================================
- Hits 5369 4498 -871
- Misses 30800 31447 +647
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
EwanC
force-pushed
the
ewan/coverity_cuda_update
branch
from
5c084e8 to
7c4a593
Compare
EwanC
changed the title
mfrancepillois
approved these changes
Feb 28, 2024
Address issues in the CUDA adapter code added by oneapi-src#1089 flagged by Coverity. * Uninitalized struct member of `CUDA_KERNEL_NODE_PARAMS` struct * copying instead of moving a shared pointer to a node when constructing a command-handle.
* Don't throw from constructor * Move rather than copy nodes during sync-point registration * Initalize `NextSyncPoint`
EwanC
force-pushed
the
ewan/coverity_cuda_update
branch
from
7c4a593 to
be622e7
Compare
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Mar 4, 2024
Test changes to the UR CUDA adapter in oneapi-src/unified-runtime#1340 that fix Coverity issues in the implementation of kernel command update in a command-buffer.
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
Mar 11, 2024
… implementation (#12723) Test changes to the UR CUDA/HIP adapters in oneapi-src/unified-runtime#1340 that fix Coverity issues in the implementation of kernel command update in a command-buffer. --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issues in the CUDA adapter code added by #1089 which have been flagged by Coverity.
CUDA_KERNEL_NODE_PARAMSstructAs well as issues flagged by coverity in the HIP adapter code added in #1254
NextSyncPointDPC++ PR intel/llvm#12723