[CL] Add UR handles to OpenCL adapter #1176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarahmed1111
force-pushed
the
Add-handles-to-opencl-adapter
branch
from
528ca1a to
26bd60a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 14.82% 12.43% -2.40%
==========================================
Files 250 241 -9
Lines 36220 36242 +22
Branches 4094 4111 +17
==========================================
- Hits 5369 4506 -863
- Misses 30800 31732 +932
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
omarahmed1111
force-pushed
the
Add-handles-to-opencl-adapter
branch
3 times, most recently
from
ceb8b8e to
ff5ebc1
Compare
omarahmed1111
changed the title
omarahmed1111
force-pushed
the
Add-handles-to-opencl-adapter
branch
10 times, most recently
from
f7b0de5 to
66d5282
Compare
omarahmed1111
force-pushed
the
Add-handles-to-opencl-adapter
branch
2 times, most recently
from
adb6b3d to
4777b93
Compare
omarahmed1111
force-pushed
the
Add-handles-to-opencl-adapter
branch
3 times, most recently
from
11b092b to
ff193b2
Compare
omarahmed1111
force-pushed
the
Add-handles-to-opencl-adapter
branch
from
ff193b2 to
2821682
Compare
Bensuo
approved these changes
Jan 16, 2024
omarahmed1111
force-pushed
the
Add-handles-to-opencl-adapter
branch
2 times, most recently
from
ab61e80 to
61ba805
Compare
omarahmed1111
commented
Jan 16, 2024
Unified Runtime -> intel/llvm Repo Move NoticeFollowing on from the previous notice, we have now enabled workflows to automatically label and close PRs because the Unified Runtime source code has moved to intel/llvm. This PR has now been marked with the Please review the previous notice for more information, including assistance with migrating your PR to intel/llvm. Should there be a reason for this PR to remain open, manually remove the This is an automated comment. |
|
This change is now here: intel/llvm@87fe117 I'll recreate an MR in intel/llvm once prerequisites are merged. |
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Mar 20, 2025
At various points, OpenCL native handles need to be retained to ensure SYCL semantics. Previously, this relied on the fact that UR handles were typecast CL handles and shared the same reference count. However, the SYCL RT shouldn't assume this, so instead we call the appropriate (dynamically looked-up) CL functions on the native handles instead. This is in preperation for oneapi-src/unified-runtime#1176 . This change should also have no observable effect for SYCL code; there is no change in lifetime semantics.
kbenzie
pushed a commit
to intel/llvm
that referenced
this pull request
Mar 21, 2025
…functions (#17016) At various points, OpenCL native handles need to be retained to ensure SYCL semantics. Previously, this relied on the fact that UR handles were typecast CL handles and shared the same reference count. However, the SYCL RT shouldn't assume this, so instead we call the appropriate (dynamically looked-up) CL functions on the native handles instead. This is in preperation for oneapi-src/unified-runtime#1176 . This change should also have no observable effect for SYCL code; there is no change in lifetime semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign OpenCL adapter by adding UR handles and get rid of the casting of the UR handles to OPENCL handles.
intel/llvm#12172