Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the workaround for handling warnings inside the loader #1851

Open
omarahmed1111 opened this issue Jul 10, 2024 · 0 comments
Open

Delete the workaround for handling warnings inside the loader #1851

omarahmed1111 opened this issue Jul 10, 2024 · 0 comments
Labels
loader Loader related feature/bug

Comments

@omarahmed1111
Copy link
Contributor

We have added a workaround for handling warning inside the loader in this PR. That workaround is needed for the deleting PI PR. However, this will be properly fixed in the new logger mechanism added by this PR. After the logger mechanism is merged, we should change the adapters entry-points that currently use UR_RESULT_ERROR_ADAPTER_SPECIFIC to report warning to use the new logger mechanism. We should attach deleting the workaround condition in the loader with the migration to use the new logger mechanism.

@omarahmed1111 omarahmed1111 added the loader Loader related feature/bug label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Loader related feature/bug
Projects
None yet
Development

No branches or pull requests

1 participant