gpu: nvidia: matmul: fix issues with scaling #2564
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently tests that use the cublasLt implementation of matmul with src, weight or dst scaling fail. This PR fixes several issues:
shared_ptr
containing the binary_pd was freed incorrectly at the end of thecreate_scaling_format_desc
function, resulting in a segmentation fault.Checklist
General
make test
andmake test_benchdnn_*
) pass locally for each commit?