generic: sycl: Inner Product FWD #2214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AD2605
changed the title
github-actions
bot
added
platform:gpu-nvidia
Rbiessy
reviewed
Nov 15, 2024
Comment on lines
-462
to
-464
| ~cudnn_matmul_impl_t() { | ||
| if (matmul_params_) { matmul_params_->cleanup(); } | ||
| } |
There was a problem hiding this comment.
Could you explain what are the consequences of this change? Are we sure matmul_params_ is cleaned up elsewhere or does it not need to?
| @@ -717,7 +717,7 @@ struct cudnn_matmul_lt_impl_t { | |||
| } | |||
| if (!params->w_blocked_) { | |||
| transform_matrix(lt_handle, params, a_layout, a, | |||
| blocked_a_layout, block_a_scratch, !params->trans_a_, | |||
| blocked_a_layout, block_a_scratch, params->trans_a_, | |||
There was a problem hiding this comment.
What is the impact of this change? Was there a bug?
| @@ -392,16 +392,16 @@ struct cudnn_matmul_lt_exec_t final : public cudnn_matmul_lt_base_exec_t { | |||
| memory_tracking::names::key_matmul_dst_in_acc_dt) | |||
| : xpu::sycl::interop_memory_arg_t< | |||
| ::sycl::access::mode::read_write>(); | |||
| auto arg_block_a_scratch = params->source_size_ != 0 | |||
There was a problem hiding this comment.
This looks like the changes in this file are fixing bugs? If so, should we consider adding more tests to catch them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the forward pass of the inner product for the generic sycl backend with support for different post-ops and data types