cpu: x64: brgemm: use range-based loop #2086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaraujom
approved these changes
Sep 6, 2024
Permanence-AI-Coder
changed the title
Permanence-AI-Coder
force-pushed
the
loop-algs-x64-jit-brdgmm-kernel-v3
branch
from
1bc730d
to
387fde8
Compare
github-actions
bot
added
the
platform:cpu-x64
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes in this PR were generated automatically by the Permanence AI Coder and reviewed by @eelenberg and @jweese. This PR replaces an iteration-based for loop over
jmp_table_labelswith a range-based for loop, which removes an unnecessary indexing variable, improves readability, and reduces potential off-by-one errors.on-behalf-of: @permanence-ai github-ai@permanence.ai
Description
Please include a summary of the change. Please also include relevant motivation and context. See contribution guidelines for more details. If the change fixes an issue not documented in the project's Github issue tracker, please document all steps necessary to reproduce it.
Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?