Skip to content

Rendering toolkit 05ispc sample addition PR #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MichaelRoyceCarroll
Copy link
Contributor

@MichaelRoyceCarroll MichaelRoyceCarroll commented Dec 10, 2021

Adding a New Sample(s)

Description

Introduce Intel ISPC compilation. ISPC is a new 2022.1 component in Rendering Toolkit.
Discussed in oneapi samples pxt brielfy (20211026 minutes)
Introduced in email thread with @MichaelRoyceCarroll @JoeOster YuryB and VadimS on 20211026.

This sample supports upcoming aims of oneAPI Rendering Toolkit Getting Started Guide. The guide will use this sample to introduce the ISPC component.

Original Source:

Original License:

Checklist

Administrative

  • Review sample design with the appropriate Domain Expert:
  • If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager

Code Development

Security and Legal

  • OSPDT Approval (see Project Manager for assistance)
  • Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
  • Bandit Scans (Python only)
  • Virus scan

Review

  • Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
  • Review readme with Tom Lenth(@tomlenth) and/or Project Manager
  • Tested using Dev Cloud when applicable

@MichaelRoyceCarroll
Copy link
Contributor Author

Looking for help on rebasing this PR properly. It doesn't look right. This should be one commit difference between oneapi-src:development and MichaelRoyceCarroll:RenderingToolkit-05ispc with my fork.... as of 20211209 4:19pm... not 69 commits!

Thanks,
-MichaelC

@praveenkk123
Copy link
Contributor

Michael,
Can you please submit this PR to "master" branch as discussed in the meeting

praveenkk123 and others added 3 commits January 14, 2022 10:20
* ONSAM-1414 Broken Link in Headers (oneapi-src#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (oneapi-src#682)

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
Co-authored-by: ericlars <eric.larson@intel.com>
Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>
Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>
@MichaelRoyceCarroll MichaelRoyceCarroll changed the base branch from development to master January 14, 2022 18:22
@MichaelRoyceCarroll
Copy link
Contributor Author

Performed rebase activity per Mike D B Tuckers guidance.

praveenkk123
praveenkk123 previously approved these changes Jan 14, 2022
Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

KanclerzPiotr
KanclerzPiotr previously approved these changes Jan 24, 2022
Copy link
Contributor

@KanclerzPiotr KanclerzPiotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

tpyra
tpyra previously requested changes Jan 25, 2022
Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>
praveenkk123
praveenkk123 previously approved these changes Mar 7, 2022
Co-authored-by: tpyra <tomasz.pyra@intel.com>
Co-authored-by: tpyra <tomasz.pyra@intel.com>
praveenkk123
praveenkk123 previously approved these changes Mar 8, 2022
@praveenkk123 praveenkk123 dismissed tpyra’s stale review March 8, 2022 22:11

code is fixed addressing the changes

@praveenkk123 praveenkk123 merged commit 7207470 into oneapi-src:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants