[oneMKL] Fix batched linear solver sample page fault #2281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Fixes a page fault that is visible when looking at dmesg output. The ipiv array must still be allocated on the host even when using the OpenMP "map" with alloc attribute. Thanks and credit goes to Sergey Kiselev (@skiselev) for rootcausing the issue and providing a fix!
External Dependencies
List any external dependencies created as a result of this change.
None
Type of change
How Has This Been Tested?
Tested locally that the page fault is visible with the sample code as written and that the page fault disappears with the change in this PR.