Skip to content

FPGA: Remove uses of the deprecated --target flag in the library flow tools #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shuoniu-intel
Copy link
Contributor

@shuoniu-intel shuoniu-intel commented Dec 19, 2023

Description

Remove uses of the deprecated --target flag in the library flow tools (fpga_crossgen, fpga_libtool).
Use of that flag causes warning: "The --target flag is deprecated and will be ignored! This tool can only be used to target sycl".

Fixes Issue: https://hsdes.intel.com/appstore/article/#/14021184709

External Dependencies

N/A

Type of change

  • CMake/README cleanup

How Has This Been Tested?

@shuoniu-intel shuoniu-intel marked this pull request as draft December 19, 2023 17:48
@shuoniu-intel shuoniu-intel marked this pull request as ready for review January 11, 2024 19:27
Copy link

@whitepau whitepau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve assuming the regtests continue to pass

@shuoniu-intel shuoniu-intel changed the title Remove uses of the deprecated --target flag in the library flow tools FPGA: Remove uses of the deprecated --target flag in the library flow tools Jan 23, 2024
@jimmytwei jimmytwei merged commit 920e25d into oneapi-src:development Jan 23, 2024
@shuoniu-intel shuoniu-intel deleted the remove-lib-flow-target-flag branch January 23, 2024 15:47
shuoniu-intel added a commit to shuoniu-intel/oneAPI-samples that referenced this pull request Jan 24, 2024
jimmytwei pushed a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants