Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check folder structure when publishing binaries #195

Open
Wambere opened this issue Jun 3, 2024 · 4 comments
Open

Check folder structure when publishing binaries #195

Wambere opened this issue Jun 3, 2024 · 4 comments
Labels
efsity FCT features

Comments

@Wambere
Copy link
Contributor

Wambere commented Jun 3, 2024

When publishing binary resources, we extract the name of the file from the composition resource and try to find the file in the project folder. This search assumes that the project is already organized in the recommended structure.

This issue is to implement a check to confirm that the folder is actually in the expected structure before trying to find the file.
If the project is not set up in the recommended structure, we can attempt to find the file in the main project folder, and if that does not work, simply show an error and skip the file

@Wambere Wambere added the efsity FCT features label Jun 3, 2024
@Wambere Wambere mentioned this issue Jun 3, 2024
2 tasks
@pld
Copy link
Member

pld commented Jun 3, 2024

Makes sense, I'd argue beyond assisting with uploading, make it easier to reuse and find information in project folders we want their structure to be consistent and a method to enforce that, which this is

@pld
Copy link
Member

pld commented Jun 14, 2024

Noted by @ndegwamartin this is also a prereq to use translation tooling

@ndegwamartin
Copy link
Contributor

@pld
Copy link
Member

pld commented Jun 14, 2024

Sounds like we're not using that structure, only requirement to verify is

/configs
/fhir_content

I don't know if translations require an structure beyond that, I guess I have to assume the main IG/composition is in /configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efsity FCT features
Projects
None yet
Development

No branches or pull requests

3 participants