Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same config file for both the importer and efsity tools #192

Open
Wambere opened this issue May 22, 2024 · 3 comments
Open

Use the same config file for both the importer and efsity tools #192

Wambere opened this issue May 22, 2024 · 3 comments
Assignees
Labels
efsity FCT features Importer

Comments

@Wambere
Copy link
Contributor

Wambere commented May 22, 2024

When setting up a new project, you need to use the importer to setup keycloak/create users/upload content, then you need to use efsity to validate and publish configs. At the moment the importer uses a config.py file for configs while efsity uses an env.properties file, both of which have more or less the same content. Is it possible to just have one env file and use it for both?

@Wambere Wambere added efsity FCT features Importer labels May 22, 2024
@pld
Copy link
Member

pld commented May 28, 2024

makes sense, probably easier to have the importer use the env.properties since Java is (imo) more picky about paths

@FikriMilano FikriMilano self-assigned this Sep 18, 2024
@FikriMilano
Copy link
Contributor

would it be a good idea to have the env.properties in the root level of the repo then? i.e. the same level as these folders and files.
if so, the todo would be to:

  1. create the env.properties file in the root level
  2. migrate importer and efsity tool to get configs from this root level env.properties (other tools might follow?)
Screen Shot 2024-09-18 at 17 27 39

@Wambere
Copy link
Contributor Author

Wambere commented Sep 18, 2024

@FikriMilano for this I think we'd want to use a .env file instead of the env.properties
The importer has already been updated to use .env so this change needs to happen to efsity
And yes, it definitely makes sense to have it at the root level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efsity FCT features Importer
Projects
None yet
Development

No branches or pull requests

3 participants