Skip to content

fix: use lodash.template directly to compile template #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2024

Conversation

danielroe
Copy link
Contributor

We are going to be removing support for compiling templates from disk using lodash.template in Nuxt v4. This is a PR to move lodash usage directly into the module to avoid breaking it on Nuxt 4.

It would also be possible to avoid using it entirely, which I would strongly recommend, either:

I note that there are a couple of places where you generate the template and consume it later, so it's possible this fix needs to be applied to more addTemplate calls than just the one I've included in the PR. But I hope it's a good start (and advance warning of the change!).

@s00d s00d merged commit c7301c9 into on-org:main May 4, 2024
@s00d
Copy link
Contributor

s00d commented May 4, 2024

Thank you very much, it's a very important change, I'll study it.

@danielroe danielroe deleted the template-compilation branch May 4, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants