Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Faraday dependency breaks error handling #73

Open
stevenringo opened this issue Apr 24, 2015 · 1 comment
Open

Removal of Faraday dependency breaks error handling #73

stevenringo opened this issue Apr 24, 2015 · 1 comment

Comments

@stevenringo
Copy link

Commit 3be4ea, release 1.3.0 refers.

Unless I am mistaken, the main OAuth2 gem as it stands (still) uses Faraday and removing Faraday here breaks any error handling raised by Faraday in the OAuth2 gem.

@twelvelabs
Copy link

Yes, OAuth2 uses Faraday and it doesn't look like it's doing any error handling of it's own: https://github.com/intridea/oauth2/blob/0ab3c213f7baa43f232eb18fa46301e1a9460f7d/lib/oauth2/client.rb#L54

Are there plans to remove faraday from OAuth2, or is this a regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants