Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should client_id/secret be mandatory? #65

Open
pedro opened this issue Nov 4, 2014 · 0 comments
Open

Should client_id/secret be mandatory? #65

pedro opened this issue Nov 4, 2014 · 0 comments

Comments

@pedro
Copy link

pedro commented Nov 4, 2014

Hey folks!

I maintain the omniauth-heroku strategy, and some of our users keep running into issues when they don't provide a proper client id and secret, which can be hard to debug because the oauth strategy will just attempt to redirect anyways.

I've added a validation to our strategy, but now wondering if this shouldn't be validated here.

Is there a use case for omniauth-oauth2 in which you don't provide a client id and secret? If not I can definitely open a pull, any feedback on how that was handled is welcome.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant