Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Net::HTTP::Persistent::Error unhandled #44

Open
sriedel opened this issue Jul 16, 2013 · 0 comments
Open

Net::HTTP::Persistent::Error unhandled #44

sriedel opened this issue Jul 16, 2013 · 0 comments

Comments

@sriedel
Copy link

sriedel commented Jul 16, 2013

The ouath2 gem uses faraday, which in turn offers the user of net-http-persistent. Faraday only transforms a timeout error to Faraday exceptions; all other Net::HTTP::Persistent::Error instances will remain as such and are re-raised.

Omniauth-oauth2 should catch such errors, and call fail!.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sriedel