Prefer double-quoted strings

Author: sferik

.rubocop.yml

@@ -0,0 +1,45 @@
+Metrics/BlockNesting:
+  Max: 2
+
+Metrics/LineLength:
+  AllowURI: true
+  Enabled: false
+
+Metrics/MethodLength:
+  CountComments: false
+  Max: 10
+
+Metrics/ParameterLists:
+  Max: 4
+  CountKeywordArgs: true
+
+Style/AccessModifierIndentation:
+  EnforcedStyle: outdent
+
+Style/CollectionMethods:
+  PreferredMethods:
+    map:      'collect'
+    reduce:   'inject'
+    find:     'detect'
+    find_all: 'select'
+
+Style/Documentation:
+  Enabled: false
+
+DotPosition:
+  EnforcedStyle: trailing
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets
+
+Style/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/TrailingComma:
+  EnforcedStyleForMultiline: 'comma'

Gemfile

@@ -1,11 +1,12 @@
-source 'http://rubygems.org'
+source "http://rubygems.org"
 
 gemspec
 
+gem "rake"
+
 group :test do
-  gem 'rack-test'
-  gem 'rake'
-  gem 'rspec', '~> 3.2'
-  gem 'simplecov'
-  gem 'webmock'
+  gem "rack-test"
+  gem "rspec", "~> 3.2"
+  gem "simplecov"
+  gem "webmock"
 end

Rakefile

@@ -1,8 +1,8 @@
 #!/usr/bin/env rake
 require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
-desc 'Default: run specs.'
+desc "Default: run specs."
 task :default => :spec
 
 desc "Run specs"

lib/omniauth-oauth.rb

@@ -1,3 +1,3 @@
 require "omniauth-oauth/version"
-require 'omniauth/strategies/oauth'
+require "omniauth/strategies/oauth"
 

lib/omniauth/strategies/oauth.rb

@@ -1,5 +1,5 @@
-require 'oauth'
-require 'omniauth'
+require "oauth"
+require "omniauth"
 
 module OmniAuth
   module Strategies
@@ -26,8 +26,8 @@ def consumer
 
       def request_phase
         request_token = consumer.get_request_token({:oauth_callback => callback_url}, options.request_params)
-        session['oauth'] ||= {}
-        session['oauth'][name.to_s] = {'callback_confirmed' => request_token.callback_confirmed?, 'request_token' => request_token.token, 'request_secret' => request_token.secret}
+        session["oauth"] ||= {}
+        session["oauth"][name.to_s] = {"callback_confirmed" => request_token.callback_confirmed?, "request_token" => request_token.token, "request_secret" => request_token.secret}
 
         if request_token.callback_confirmed?
           redirect request_token.authorize_url(options[:authorize_params])
@@ -42,13 +42,13 @@ def request_phase
       end
 
       def callback_phase
-        raise OmniAuth::NoSessionError.new("Session Expired") if session['oauth'].nil?
+        raise OmniAuth::NoSessionError.new("Session Expired") if session["oauth"].nil?
 
-        request_token = ::OAuth::RequestToken.new(consumer, session['oauth'][name.to_s].delete('request_token'), session['oauth'][name.to_s].delete('request_secret'))
+        request_token = ::OAuth::RequestToken.new(consumer, session["oauth"][name.to_s].delete("request_token"), session["oauth"][name.to_s].delete("request_secret"))
 
         opts = {}
-        if session['oauth'][name.to_s]['callback_confirmed']
-          opts[:oauth_verifier] = request['oauth_verifier']
+        if session["oauth"][name.to_s]["callback_confirmed"]
+          opts[:oauth_verifier] = request["oauth_verifier"]
         else
           opts[:oauth_callback] = callback_url
         end
@@ -66,14 +66,14 @@ def callback_phase
       end
 
       credentials do
-        {'token' => access_token.token, 'secret' => access_token.secret}
+        {"token" => access_token.token, "secret" => access_token.secret}
       end
 
       extra do
-        {'access_token' => access_token}
+        {"access_token" => access_token}
       end
     end
   end
 end
 
-OmniAuth.config.add_camelization 'oauth', 'OAuth'
+OmniAuth.config.add_camelization "oauth", "OAuth"

omniauth-oauth.gemspec

@@ -1,5 +1,5 @@
 # -*- encoding: utf-8 -*-
-require File.expand_path('../lib/omniauth-oauth/version', __FILE__)
+require File.expand_path("../lib/omniauth-oauth/version", __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ["Michael Bleigh"]
@@ -9,15 +9,15 @@ Gem::Specification.new do |gem|
   gem.homepage      = "https://github.com/intridea/omniauth-oauth"
   gem.license       = "MIT"
 
-  gem.add_dependency 'omniauth', '~> 1.0'
-  gem.add_dependency 'oauth'
-  gem.add_development_dependency 'bundler', '~> 1.9'
+  gem.add_dependency "omniauth", "~> 1.0"
+  gem.add_dependency "oauth"
+  gem.add_development_dependency "bundler", "~> 1.9"
 
   gem.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   gem.files         = `git ls-files`.split("\n")
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.name          = "omniauth-oauth"
   gem.require_paths = ["lib"]
   gem.version       = OmniAuth::OAuth::VERSION
-  gem.license       = 'MIT'
+  gem.license       = "MIT"
 end

spec/omniauth/strategies/oauth_spec.rb

@@ -1,147 +1,147 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe "OmniAuth::Strategies::OAuth" do
   class MyOAuthProvider < OmniAuth::Strategies::OAuth
     uid{ access_token.token }
-    info{ {'name' => access_token.token} }
+    info{ {"name" => access_token.token} }
   end
 
   def app
     Rack::Builder.new {
       use OmniAuth::Test::PhonySession
       use OmniAuth::Builder do
-        provider MyOAuthProvider, 'abc', 'def', :client_options => {:site => 'https://api.example.org'}, :name => 'example.org'
-        provider MyOAuthProvider, 'abc', 'def', :client_options => {:site => 'https://api.example.org'}, :authorize_params => {:abc => 'def'}, :name => 'example.org_with_authorize_params'
-        provider MyOAuthProvider, 'abc', 'def', :client_options => {:site => 'https://api.example.org'}, :request_params => {:scope => 'http://foobar.example.org'}, :name => 'example.org_with_request_params'
+        provider MyOAuthProvider, "abc", "def", :client_options => {:site => "https://api.example.org"}, :name => "example.org"
+        provider MyOAuthProvider, "abc", "def", :client_options => {:site => "https://api.example.org"}, :authorize_params => {:abc => "def"}, :name => "example.org_with_authorize_params"
+        provider MyOAuthProvider, "abc", "def", :client_options => {:site => "https://api.example.org"}, :request_params => {:scope => "http://foobar.example.org"}, :name => "example.org_with_request_params"
       end
-      run lambda { |env| [404, {'Content-Type' => 'text/plain'}, [env.key?('omniauth.auth').to_s]] }
+      run lambda { |env| [404, {"Content-Type" => "text/plain"}, [env.key?("omniauth.auth").to_s]] }
     }.to_app
   end
 
   def session
-    last_request.env['rack.session']
+    last_request.env["rack.session"]
   end
 
   before do
-    stub_request(:post, 'https://api.example.org/oauth/request_token').
+    stub_request(:post, "https://api.example.org/oauth/request_token").
        to_return(:body => "oauth_token=yourtoken&oauth_token_secret=yoursecret&oauth_callback_confirmed=true")
   end
 
-  it 'should add a camelization for itself' do
-    expect(OmniAuth::Utils.camelize('oauth')).to eq('OAuth')
+  it "should add a camelization for itself" do
+    expect(OmniAuth::Utils.camelize("oauth")).to eq("OAuth")
   end
 
-  describe '/auth/{name}' do
-    context 'successful' do
+  describe "/auth/{name}" do
+    context "successful" do
       before do
-        get '/auth/example.org'
+        get "/auth/example.org"
       end
 
-      it 'should redirect to authorize_url' do
+      it "should redirect to authorize_url" do
         expect(last_response).to be_redirect
-        expect(last_response.headers['Location']).to eq('https://api.example.org/oauth/authorize?oauth_token=yourtoken')
+        expect(last_response.headers["Location"]).to eq("https://api.example.org/oauth/authorize?oauth_token=yourtoken")
       end
 
-      it 'should redirect to authorize_url with authorize_params when set' do
-        get '/auth/example.org_with_authorize_params'
+      it "should redirect to authorize_url with authorize_params when set" do
+        get "/auth/example.org_with_authorize_params"
         expect(last_response).to be_redirect
         expect([
-          'https://api.example.org/oauth/authorize?abc=def&oauth_token=yourtoken',
-          'https://api.example.org/oauth/authorize?oauth_token=yourtoken&abc=def'
-        ]).to be_include(last_response.headers['Location'])
+          "https://api.example.org/oauth/authorize?abc=def&oauth_token=yourtoken",
+          "https://api.example.org/oauth/authorize?oauth_token=yourtoken&abc=def"
+        ]).to be_include(last_response.headers["Location"])
       end
 
-      it 'should set appropriate session variables' do
-        expect(session['oauth']).to eq({"example.org" => {'callback_confirmed' => true, 'request_token' => 'yourtoken', 'request_secret' => 'yoursecret'}})
+      it "should set appropriate session variables" do
+        expect(session["oauth"]).to eq({"example.org" => {"callback_confirmed" => true, "request_token" => "yourtoken", "request_secret" => "yoursecret"}})
       end
 
-      it 'should pass request_params to get_request_token' do
-        get '/auth/example.org_with_request_params'
-        expect(WebMock).to have_requested(:post, 'https://api.example.org/oauth/request_token').
+      it "should pass request_params to get_request_token" do
+        get "/auth/example.org_with_request_params"
+        expect(WebMock).to have_requested(:post, "https://api.example.org/oauth/request_token").
            with {|req| req.body == "scope=http%3A%2F%2Ffoobar.example.org" }
       end
     end
 
-    context 'unsuccessful' do
+    context "unsuccessful" do
       before do
-        stub_request(:post, 'https://api.example.org/oauth/request_token').
+        stub_request(:post, "https://api.example.org/oauth/request_token").
            to_raise(::Net::HTTPFatalError.new(%Q{502 "Bad Gateway"}, nil))
-        get '/auth/example.org'
+        get "/auth/example.org"
       end
 
-      it 'should call fail! with :service_unavailable' do
-        expect(last_request.env['omniauth.error']).to be_kind_of(::Net::HTTPFatalError)
-        last_request.env['omniauth.error.type'] = :service_unavailable
+      it "should call fail! with :service_unavailable" do
+        expect(last_request.env["omniauth.error"]).to be_kind_of(::Net::HTTPFatalError)
+        last_request.env["omniauth.error.type"] = :service_unavailable
       end
 
       context "SSL failure" do
         before do
-          stub_request(:post, 'https://api.example.org/oauth/request_token').
+          stub_request(:post, "https://api.example.org/oauth/request_token").
              to_raise(::OpenSSL::SSL::SSLError.new("SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed"))
-          get '/auth/example.org'
+          get "/auth/example.org"
         end
 
-        it 'should call fail! with :service_unavailable' do
-          expect(last_request.env['omniauth.error']).to be_kind_of(::OpenSSL::SSL::SSLError)
-          last_request.env['omniauth.error.type'] = :service_unavailable
+        it "should call fail! with :service_unavailable" do
+          expect(last_request.env["omniauth.error"]).to be_kind_of(::OpenSSL::SSL::SSLError)
+          last_request.env["omniauth.error.type"] = :service_unavailable
         end
       end
     end
   end
 
-    describe '/auth/{name}/callback' do
+    describe "/auth/{name}/callback" do
       before do
-        stub_request(:post, 'https://api.example.org/oauth/access_token').
+        stub_request(:post, "https://api.example.org/oauth/access_token").
          to_return(:body => "oauth_token=yourtoken&oauth_token_secret=yoursecret")
-      get '/auth/example.org/callback', {:oauth_verifier => 'dudeman'}, {'rack.session' => {'oauth' => {"example.org" => {'callback_confirmed' => true, 'request_token' => 'yourtoken', 'request_secret' => 'yoursecret'}}}}
+      get "/auth/example.org/callback", {:oauth_verifier => "dudeman"}, {"rack.session" => {"oauth" => {"example.org" => {"callback_confirmed" => true, "request_token" => "yourtoken", "request_secret" => "yoursecret"}}}}
     end
 
-    it 'should exchange the request token for an access token' do
-      expect(last_request.env['omniauth.auth']['provider']).to eq('example.org')
-      expect(last_request.env['omniauth.auth']['extra']['access_token']).to be_kind_of(OAuth::AccessToken)
+    it "should exchange the request token for an access token" do
+      expect(last_request.env["omniauth.auth"]["provider"]).to eq("example.org")
+      expect(last_request.env["omniauth.auth"]["extra"]["access_token"]).to be_kind_of(OAuth::AccessToken)
     end
 
-    it 'should call through to the master app' do
-      expect(last_response.body).to eq('true')
+    it "should call through to the master app" do
+      expect(last_response.body).to eq("true")
     end
 
     context "bad gateway (or any 5xx) for access_token" do
       before do
-        stub_request(:post, 'https://api.example.org/oauth/access_token').
+        stub_request(:post, "https://api.example.org/oauth/access_token").
            to_raise(::Net::HTTPFatalError.new(%Q{502 "Bad Gateway"}, nil))
-        get '/auth/example.org/callback', {:oauth_verifier => 'dudeman'}, {'rack.session' => {'oauth' => {"example.org" => {'callback_confirmed' => true, 'request_token' => 'yourtoken', 'request_secret' => 'yoursecret'}}}}
+        get "/auth/example.org/callback", {:oauth_verifier => "dudeman"}, {"rack.session" => {"oauth" => {"example.org" => {"callback_confirmed" => true, "request_token" => "yourtoken", "request_secret" => "yoursecret"}}}}
       end
 
-      it 'should call fail! with :service_unavailable' do
-        expect(last_request.env['omniauth.error']).to be_kind_of(::Net::HTTPFatalError)
-        last_request.env['omniauth.error.type'] = :service_unavailable
+      it "should call fail! with :service_unavailable" do
+        expect(last_request.env["omniauth.error"]).to be_kind_of(::Net::HTTPFatalError)
+        last_request.env["omniauth.error.type"] = :service_unavailable
       end
     end
 
     context "SSL failure" do
       before do
-        stub_request(:post, 'https://api.example.org/oauth/access_token').
+        stub_request(:post, "https://api.example.org/oauth/access_token").
            to_raise(::OpenSSL::SSL::SSLError.new("SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed"))
-        get '/auth/example.org/callback', {:oauth_verifier => 'dudeman'}, {'rack.session' => {'oauth' => {"example.org" => {'callback_confirmed' => true, 'request_token' => 'yourtoken', 'request_secret' => 'yoursecret'}}}}
+        get "/auth/example.org/callback", {:oauth_verifier => "dudeman"}, {"rack.session" => {"oauth" => {"example.org" => {"callback_confirmed" => true, "request_token" => "yourtoken", "request_secret" => "yoursecret"}}}}
       end
 
-      it 'should call fail! with :service_unavailable' do
-        expect(last_request.env['omniauth.error']).to be_kind_of(::OpenSSL::SSL::SSLError)
-        last_request.env['omniauth.error.type'] = :service_unavailable
+      it "should call fail! with :service_unavailable" do
+        expect(last_request.env["omniauth.error"]).to be_kind_of(::OpenSSL::SSL::SSLError)
+        last_request.env["omniauth.error.type"] = :service_unavailable
       end
     end
   end
 
-  describe '/auth/{name}/callback with expired session' do
+  describe "/auth/{name}/callback with expired session" do
     before do
-      stub_request(:post, 'https://api.example.org/oauth/access_token').
+      stub_request(:post, "https://api.example.org/oauth/access_token").
          to_return(:body => "oauth_token=yourtoken&oauth_token_secret=yoursecret")
-      get '/auth/example.org/callback', {:oauth_verifier => 'dudeman'}, {'rack.session' => {}}
+      get "/auth/example.org/callback", {:oauth_verifier => "dudeman"}, {"rack.session" => {}}
     end
 
-    it 'should call fail! with :session_expired' do
-      expect(last_request.env['omniauth.error']).to be_kind_of(::OmniAuth::NoSessionError)
-      last_request.env['omniauth.error.type'] = :session_expired
+    it "should call fail! with :session_expired" do
+      expect(last_request.env["omniauth.error"]).to be_kind_of(::OmniAuth::NoSessionError)
+      last_request.env["omniauth.error.type"] = :session_expired
     end
   end
 end

spec/spec_helper.rb

@@ -1,14 +1,14 @@
-$:.unshift File.expand_path('..', __FILE__)
-$:.unshift File.expand_path('../../lib', __FILE__)
-require 'simplecov'
+$:.unshift File.expand_path("..", __FILE__)
+$:.unshift File.expand_path("../../lib", __FILE__)
+require "simplecov"
 SimpleCov.start do
   minimum_coverage(89.8)
 end
-require 'rspec'
-require 'rack/test'
-require 'webmock/rspec'
-require 'omniauth'
-require 'omniauth-oauth'
+require "rspec"
+require "rack/test"
+require "webmock/rspec"
+require "omniauth"
+require "omniauth-oauth"
 
 RSpec.configure do |config|
   config.include WebMock::API