From fd4bec0c55ce14efe50b700fa405c3c9c8aec7a2 Mon Sep 17 00:00:00 2001
From: "Gregor G." <75445744+sideninja@users.noreply.github.com>
Date: Wed, 16 Oct 2024 14:48:40 +0200
Subject: [PATCH] chore(e2e): improve comments and naming (#2188)

Add comments explaining roles.

issue: none
---
 e2e/app/eoa/eoa.go        | 9 ++++++++-
 e2e/app/portalregistry.go | 4 ++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/e2e/app/eoa/eoa.go b/e2e/app/eoa/eoa.go
index 9d7002b4e..d48ac747f 100644
--- a/e2e/app/eoa/eoa.go
+++ b/e2e/app/eoa/eoa.go
@@ -26,9 +26,16 @@ const (
 	// RoleDeployer is used to deploy official omni contracts on all chains.
 	RoleDeployer Role = "deployer"
 	// RoleManager is used to manage the omni contracts on all chains. It has admin privileges on official omni contracts.
-	// The role can pause, unpause and configure contracts.
+	// The manager can make non-compromising managing actions:
+	// - managing validator allow list
+	// - pausing / unpausing contracts
+	// - configuration of contracts.
 	RoleManager Role = "manager"
 	// RoleUpgrader is the owner of each proxy contract and can trigger upgrade actions.
+	// The upgrader can do compromising destructive actions:
+	// - trigger / cancel upgrade actions
+	// - trigger Halo upgrades
+	// - register new portals.
 	RoleUpgrader Role = "upgrader"
 	// RoleTester is used for general tasks and testing in non-mainnet networks.
 	RoleTester Role = "tester"
diff --git a/e2e/app/portalregistry.go b/e2e/app/portalregistry.go
index d11dbfccd..cd5224912 100644
--- a/e2e/app/portalregistry.go
+++ b/e2e/app/portalregistry.go
@@ -64,8 +64,8 @@ func newRegistryMngr(ctx context.Context, def Definition) (registryMngr, error)
 		return registryMngr{}, errors.Wrap(err, "new portal registry")
 	}
 
-	manager := eoa.MustAddress(def.Testnet.Network, eoa.RoleUpgrader)
-	txOpts, err := backend.BindOpts(ctx, manager)
+	upgrader := eoa.MustAddress(def.Testnet.Network, eoa.RoleUpgrader)
+	txOpts, err := backend.BindOpts(ctx, upgrader)
 	if err != nil {
 		return registryMngr{}, err
 	}