Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site in subdirectory feature doesn't work in Octopus #1208

Open
omega8cc opened this issue Sep 11, 2017 · 2 comments
Open

Site in subdirectory feature doesn't work in Octopus #1208

omega8cc opened this issue Sep 11, 2017 · 2 comments

Comments

@omega8cc
Copy link
Owner

The Aegir code for site in subdirectory support is not even called on Octopus Satellite instances, while it just works on Barracuda Master instance. This obviously means that we have managed to introduce a bug/regression which we need to find and fix.

We have already determined that it's not related to our Drush version nor to our Provision version, because both the Barracuda Master and Octopus Satellite use the same version of Drush and Provision.

It's also not related to Octopus specific BOA features configuration, because the problem persists even with the Octopus specific feature disabled.

@omega8cc
Copy link
Owner Author

We have narrowed the bug hunting to HTTPS support, which perhaps somehow conflicts with Subdir support. Enabling HTTPS modules in Hostmaster doesn't break things, it happens after switching web server configuration to HTTPS mode. At least we know where exactly to dig further.

@omega8cc
Copy link
Owner Author

It's actually a missing feature in Aegir itself, not a bug in BOA. Currently Aegir simply doesn't support Subdirs once HTTPS mode is active, because only the code related to plain HTTP has Subdir class, or rather, HTTPS and Subdirs are two parallel branches in the code, not connected and/or inherited (yet). It's probably a matter of current code (classes) structure, so not a simple bug to fix :/

/**
 * Base class for subdir support.
 *
 * This class will publish the config files to remote
 * servers automatically.
 */
class Provision_Config_Nginx_Subdir extends Provision_Config_Http {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant