Convert HTML tables to Markdown tables #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jabalazs thanks for the PR! Are you planning to convert the other remaining tables? As for Table 3, we will think about how to best split it. |
|
I just finished converting the remaining tables! As for table 3, just tell me whenever you make a decision and I'll convert it as well. |
|
@jabalazs Awesome! Okay, you can go ahead and split table 3 into two tables (Dependency Parsing and Constituency Parsing) and you can include the descriptions below for the two tables. How about that? Descriptions for Table 3 Table 3.2: Constituency Parsing |
|
Sounds good! I'll split it now then. |
- Move score descriptions to table headers - Change table titles accordingly - Change "F1 Score" to "F1 %" for consistency with the other tables
jabalazs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm converting HTML tables to markdown following kramdown specifications, as suggested in #1.
I still haven't converted table 3 because the HTML version contains multi-line cells, which kramdown doesn't support. Should we keep the HTML version? or perhaps separate that table into 2 separate tables, one for dependency parsing, and another for constituency parsing?