Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to "context" from stdlib when 1.8 comes out #425

Closed
olivere opened this issue Dec 25, 2016 · 6 comments
Closed

Switch to "context" from stdlib when 1.8 comes out #425

olivere opened this issue Dec 25, 2016 · 6 comments
Assignees

Comments

@olivere
Copy link
Owner

olivere commented Dec 25, 2016

We want to switch from "golang.org/x/net/context" to "context" when 1.8 is ready.

@olivere olivere added this to the 6.0 milestone Jan 28, 2017
@olivere olivere self-assigned this Jan 28, 2017
@olivere olivere removed this from the 6.0 milestone Jan 28, 2017
@eticzon
Copy link
Contributor

eticzon commented Apr 21, 2017

Hi @olivere! Thanks for this awesome lib! I'd like to get involved, if that's OK. 😄 Would you mind if I start with this "admin"-y task first?

@olivere
Copy link
Owner Author

olivere commented Apr 21, 2017

@eticzon I'd appreciate support if you're ready to spend some of your time. I agree changing golang.org/x/net/context to context should be pretty straightforward. So if you want, feel free to create a PR. Please do so for v5 first.

@eticzon
Copy link
Contributor

eticzon commented Apr 21, 2017

Thanks @olivere! Much appreciated! PR's up as well when you've got time to review.

@olivere
Copy link
Owner Author

olivere commented Apr 21, 2017

@eticzon I haven't looked into this recently. But can we also switch away from golang.org/x/net/context/ctxhttp now that we have WithContext(...) in stdlib?

@eticzon
Copy link
Contributor

eticzon commented Apr 21, 2017

Good point @olivere. I'll change the calls to ctxhttp then and replace them WithContext(...) alternatives.

eticzon added a commit to eticzon/elastic that referenced this issue Apr 23, 2017
eticzon added a commit to eticzon/elastic that referenced this issue Apr 23, 2017
olivere pushed a commit that referenced this issue Apr 23, 2017
This commit switches Elastic v5 from `"golang.org/x/net/context"` to stdlib `"context"`. It also removes `ctxhttp` and uses stlib `http.Request.WithContext(...)` .

See #425
@olivere
Copy link
Owner Author

olivere commented Apr 23, 2017

Thanks so much for working on this. It's been tagged as 5.0.36 now.

@olivere olivere closed this as completed Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants