-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to "context" from stdlib when 1.8 comes out #425
Comments
Hi @olivere! Thanks for this awesome lib! I'd like to get involved, if that's OK. 😄 Would you mind if I start with this "admin"-y task first? |
@eticzon I'd appreciate support if you're ready to spend some of your time. I agree changing |
Thanks @olivere! Much appreciated! PR's up as well when you've got time to review. |
@eticzon I haven't looked into this recently. But can we also switch away from |
Good point @olivere. I'll change the calls to |
This commit switches Elastic v5 from `"golang.org/x/net/context"` to stdlib `"context"`. It also removes `ctxhttp` and uses stlib `http.Request.WithContext(...)` . See #425
Thanks so much for working on this. It's been tagged as 5.0.36 now. |
We want to switch from
"golang.org/x/net/context"
to"context"
when 1.8 is ready.The text was updated successfully, but these errors were encountered: